Various compilation fixes

Various compilation errors I encountered on Windows, macOS and Linux.

OpenMP is now handled in OTB itself with the OTB_USE_OPENMP setting.

Hello,

I have tried on CNES cluster (HAL) the OTB_USE_OPENMP setting with a -DOTB_USE_OPENMP=ON for the cmake command. The variable is reset to OFF during the configuration (after the find_package(OTB REQUIRED) line into CMakeLists.txt) and so the error "Diapotb remote module needs OpenMP, compile OTB with OTB_USE_OPENMP=ON" occurs.

Does this behaviour seem normal to you?

Thanks. Gaëlle.

I guess you are building the module diapotb in standalone mode (outside OTB build tree). I think you are using an OTB that is compiled without openMP, so the find_package(OTB) will set OTB_USE_OPENMP to OFF (check your OTBConfig.cmake). Maybe we should allow that this module can be built in standalone with its own find_package(OpenMP). I'll prepare a fix.

added 1 commit

• 7d370289 - COMP: call find_package(OpenMP) in standalone mode

Compare with previous version

That's right, I'm using diapotb in standalone mode and on HAL, the OTB configuration set OTB_USE_OPENMP to OFF. Thanks to your fix (and with a correct openmp installation), that works for standalone mode too.

mentioned in commit 6f7f5c27

merged