include max radius and MAX_RADIUS, WINDOW_SIZE constants

There we add the max_radius argument to LIS, following the ongoing fix in rastertools:

https://github.com/CNES/rastertools/pull/1

added enhancement label

requested review from @guillaumeeb

assigned to @micherbl

So, instead of constants, we should use condig values. Typically, radius config values should be replaced by max_radius (in LIS, we always want to specify a max radius, not a radius that can be overriden). The line https://gitlab.orfeo-toolbox.org/remote_modules/let-it-snow/-/blob/develop/python/s2snow/fsc_config.py?ref_type=heads#L262 should be modified, and this value used when calling rastertools.

Also, default windows_size should be 2048, as it is fine with a 512 pixels radius.

added 1 commit

• 54079aae - Following rastertools fix in github

Compare with previous version

Ok I better understood how max_radius should be defined in LIS. I am submitting another fix

added 1 commit

• ec774d0e - Hillshade has only one 'radius' argument left

Compare with previous version

added 1 commit

• c57b4482 - change rastertools_max_radius back to rastertools_radius

Compare with previous version

added 1 commit

• 4171c4c3 - add informative log

Compare with previous version

resolved all threads

mentioned in commit 8fdba5d8

merged

mentioned in issue #126 (closed)