Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
otb
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Antoine Belvire
otb
Commits
00a5b325
Commit
00a5b325
authored
15 years ago
by
Julien Michel
Browse files
Options
Downloads
Patches
Plain Diff
BUG: Deactivating multithreading in INVERSE case until the bug is fixed
parent
a97ebae3
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Code/MultiScale/otbSubsampleImageFilter.txx
+1
-0
1 addition, 0 deletions
Code/MultiScale/otbSubsampleImageFilter.txx
Code/MultiScale/otbWaveletFilterBank.txx
+9
-1
9 additions, 1 deletion
Code/MultiScale/otbWaveletFilterBank.txx
with
10 additions
and
1 deletion
Code/MultiScale/otbSubsampleImageFilter.txx
+
1
−
0
View file @
00a5b325
...
...
@@ -97,6 +97,7 @@ SubsampleImageFilter< TInputImage, TOutputImage, TDirectionOfTransformation >
for ( unsigned int i = 0; i < InputImageDimension; i++ )
{
// TODO: This seems not right in odd index cases
destIndex[i] = srcIndex[i] / m_SubsampleFactor[i];
destSize[i] = srcSize[i] / m_SubsampleFactor[i];
}
...
...
This diff is collapsed.
Click to expand it.
Code/MultiScale/otbWaveletFilterBank.txx
+
9
−
1
View file @
00a5b325
...
...
@@ -328,6 +328,7 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::FORWARD
for ( unsigned int i = 0; i < InputImageDimension; i++ )
{
// TODO: This seems not right in odd index cases
destIndex[i] = srcIndex[i] / GetSubsampleImageFactor();
destSize[i] = srcSize[i] / GetSubsampleImageFactor();
}
...
...
@@ -358,6 +359,7 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::FORWARD
{
if ( i == direction )
{
// TODO: This seems not right in odd index cases
destIndex[i] = srcIndex[i] / GetSubsampleImageFactor();
destSize[i] = srcSize[i] / GetSubsampleImageFactor();
}
...
...
@@ -633,7 +635,9 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::INVERSE
m_UpSampleFilterFactor = 0;
m_SubsampleImageFactor = 1;
//this->SetNumberOfThreads(1);
// TODO: For now, we force the number threads to 1 because there is a bug with multithreading in INVERSE transform
// Resulting in discontinuities in the reconstructed images
this->SetNumberOfThreads(1);
}
template < class TInputImage, class TOutputImage, class TWaveletOperator >
...
...
@@ -799,6 +803,7 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::INVERSE
for ( unsigned int i = 0; i < InputImageDimension; i++ )
{
// TODO: This seems not right in odd index cases
destIndex[i] = srcIndex[i] / GetSubsampleImageFactor();
destSize[i] = srcSize[i] / GetSubsampleImageFactor();
}
...
...
@@ -893,6 +898,7 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::INVERSE
{
if ( i == direction )
{
// TODO: This seems not right in odd index cases
destIndex[i] = srcIndex[i] / GetSubsampleImageFactor();
destSize[i] = srcSize[i] / GetSubsampleImageFactor();
}
...
...
@@ -1236,6 +1242,8 @@ WaveletFilterBank< TInputImage, TOutputImage, TWaveletOperator, Wavelet::INVERSE
itk::ImageRegionIterator< OutputImageType > out ( outputImage,
overSampledLowPass->GetOutput()->GetRequestedRegion() );
// TODO: This might be the cause of the multithreading bug : we use a neighborhood iterator on cropped data
// Are we sure that we have cropped enough data to access the neighborhood ?
NeighborhoodIteratorType lowIter ( lowPassOperator.GetRadius(),
overSampledLowPass->GetOutput(), overSampledLowPass->GetOutput()->GetRequestedRegion() );
itk::PeriodicBoundaryCondition< OutputImageType > boundaryCondition;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment