STYLE: This class should not derive from InPlaceImageFilter, even with InPlaceOff().

Code/Common/otbBinaryFunctorNeighborhoodImageFilter.h

@@ -18,7 +18,7 @@
 #ifndef __otbBinaryFunctorNeighborhoodImageFilter_h
 #define __otbBinaryFunctorNeighborhoodImageFilter_h
 
-#include "itkBinaryFunctorImageFilter.h"
+#include "itkImageToImageFilter.h"
 #include "itkImageRegionIteratorWithIndex.h"
 #include "itkConstNeighborhoodIterator.h"
 
@@ -36,12 +36,12 @@ namespace otb
  */
 template <class TInputImage1, class TInputImage2, 
           class TOutputImage, class TFunction    >
-class ITK_EXPORT BinaryFunctorNeighborhoodImageFilter : public itk::InPlaceImageFilter<TInputImage1,TOutputImage> 
+  class ITK_EXPORT BinaryFunctorNeighborhoodImageFilter : public itk::ImageToImageFilter<TInputImage1,TOutputImage>
 {
 public:
   /** Standard class typedefs. */
   typedef BinaryFunctorNeighborhoodImageFilter  Self;
-  typedef itk::BinaryFunctorImageFilter<TInputImage1,TInputImage2,TOutputImage,TFunction>   Superclass;
+  typedef itk::ImageToImageFilter<TInputImage1,TOutputImage> Superclass;
   typedef itk::SmartPointer<Self>   Pointer;
   typedef itk::SmartPointer<const Self>  ConstPointer;
 
@@ -65,7 +65,7 @@ public:
   typedef TOutputImage OutputImageType;
   typedef typename OutputImageType::Pointer OutputImagePointer;
   typedef typename OutputImageType::RegionType OutputImageRegionType;
-  typedef typename OutputImageType::PixelType OutputImagePixelType;
+  typedef typename OutputImageType::PixelType OutputImagePixelType;
 
   typedef itk::ProcessObject ProcessObjectType;
 

Code/Common/otbBinaryFunctorNeighborhoodImageFilter.txx

@@ -36,7 +36,6 @@ BinaryFunctorNeighborhoodImageFilter<TInputImage1,TInputImage2,TOutputImage,TFun
 ::BinaryFunctorNeighborhoodImageFilter()
 {
   this->SetNumberOfRequiredInputs( 2 );
-  this->InPlaceOff();
   m_Radius = 3;
 }