WRG: fix other clang7 warnings

Modules/Core/Common/src/otbExtendedFilenameHelper.cxx

@@ -25,10 +25,6 @@
 #include <stdexcept>
 #include <string>
 
-#include <boost/algorithm/string.hpp>
-#include <boost/lexical_cast.hpp>
-
-#include "otb_boost_string_header.h"
 #include "otbStringUtils.h"
 
 namespace otb

Modules/Filtering/MathParser/include/otbBandMathImageFilter.hxx

@@ -147,7 +147,6 @@ void BandMathImageFilter<TImage>
 ::BeforeThreadedGenerateData()
 {
   typename std::vector<ParserType::Pointer>::iterator        itParser;
-  typename std::vector< std::vector<PixelType> >::iterator   itVImage;
   unsigned int nbThreads = this->GetNumberOfThreads();
   unsigned int nbInputImages = this->GetNumberOfInputs();
   unsigned int nbAccessIndex = 4; //to give access to image and physical index

Modules/Filtering/MathParserX/include/otbParserX.h

@@ -28,8 +28,9 @@
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wc++11-extensions"
 
+#if defined(__apple_build_version__) &&  __apple_build_version__ < 7000053
 /* Apple's 3.6.0 based clang doesn't support -Winconsistent-missing-override */
-#if defined(__apple_build_version__) &&  __apple_build_version__ >= 7000053
+#else
 #pragma clang diagnostic ignored "-Winconsistent-missing-override"
 #endif
 

Modules/Learning/DimensionalityReductionLearning/include/otbAutoencoderModel.h

@@ -30,9 +30,11 @@
 #pragma GCC diagnostic ignored "-Wunused-parameter"
 #pragma GCC diagnostic ignored "-Woverloaded-virtual"
 #pragma GCC diagnostic ignored "-Wsign-compare"
+#pragma GCC diagnostic ignored "-Wunused-local-typedefs"
 #if defined(__clang__)
 #pragma clang diagnostic ignored "-Wheader-guard"
 #pragma clang diagnostic ignored "-Wdivision-by-zero"
+#pragma clang diagnostic ignored "-Wexpansion-to-defined"
 #else
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif

Modules/Learning/DimensionalityReductionLearning/include/otbPCAModel.h

@@ -29,8 +29,10 @@
 #pragma GCC diagnostic ignored "-Wunused-parameter"
 #pragma GCC diagnostic ignored "-Woverloaded-virtual"
 #pragma GCC diagnostic ignored "-Wsign-compare"
+#pragma GCC diagnostic ignored "-Wunused-local-typedefs"
 #if defined(__clang__)
 #pragma clang diagnostic ignored "-Wheader-guard"
+#pragma clang diagnostic ignored "-Wexpansion-to-defined"
 #else
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif

Modules/Learning/Supervised/include/otbSharkRandomForestsMachineLearningModel.h

@@ -34,8 +34,10 @@
 #pragma GCC diagnostic ignored "-Wcast-align"
 #pragma GCC diagnostic ignored "-Wunknown-pragmas"
 #pragma GCC diagnostic ignored "-Wmissing-field-initializers"
+#pragma GCC diagnostic ignored "-Wunused-local-typedefs"
 #if defined(__clang__)
 #pragma clang diagnostic ignored "-Wheader-guard"
+#pragma clang diagnostic ignored "-Wexpansion-to-defined"
 #else
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif

Modules/Learning/Unsupervised/include/otbSharkKMeansMachineLearningModel.h

@@ -33,8 +33,10 @@
 #pragma GCC diagnostic ignored "-Wsign-compare"
 #pragma GCC diagnostic ignored "-Wcast-align"
 #pragma GCC diagnostic ignored "-Wunknown-pragmas"
+#pragma GCC diagnostic ignored "-Wunused-local-typedefs"
 #if defined(__clang__)
 #pragma clang diagnostic ignored "-Wheader-guard"
+#pragma clang diagnostic ignored "-Wexpansion-to-defined"
 #else
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
 #endif

Modules/Visualization/Ice/include/otbNonOptGlImageActor.h

@@ -56,16 +56,16 @@ public:
   void Initialize(const std::string & filename);
 
   // Retrieve the full extent of the actor
-  virtual void GetExtent(double & ulx, double & uly, double & lrx, double & lry) const;
+  void GetExtent(double & ulx, double & uly, double & lrx, double & lry) const override;
 
   // Update internal actor state with respect to ViewSettings
-  virtual void ProcessViewSettings();
+  void ProcessViewSettings() override;
 
   // Heavy load/unload operations of data
-  virtual void UpdateData();
+  void UpdateData() override;
 
   // Gl rendering of current state
-  virtual void Render();
+  void Render() override;
 
   const PointType & GetOrigin() const;