ENH: Since GetContingencyTable() is not a simple getter (it computes new...

ENH: Since GetContingencyTable() is not a simple getter (it computes new things), change name to less ambiguous BuildContingencyTable()

Modules/Applications/AppClassification/app/otbComputeConfusionMatrix.cxx

@@ -390,7 +390,7 @@ private:
       calculator->Compute( itRef, itInput,sid.refhasnodata,sid.refnodata,sid.prodhasnodata,sid.prodnodata);
       }
 
-    ContingencyTableType contingencyTable = calculator->GetContingencyTable();
+    ContingencyTableType contingencyTable = calculator->BuildContingencyTable();
     LogContingencyTable(contingencyTable);
     writeContingencyTable(contingencyTable);
   }

Modules/Applications/AppClassification/app/otbTrainVectorClassifier.cxx

@@ -102,9 +102,9 @@ private:
 
     otbAppLogINFO( "Training performances:" );
 
-    otbAppLogINFO(<<"Contingency table: reference labels (rows) vs. produced labels (cols)\n"<<contingencyTableCalculator->GetContingencyTable());
+    otbAppLogINFO(<<"Contingency table: reference labels (rows) vs. produced labels (cols)\n"<<contingencyTableCalculator->BuildContingencyTable());
     
-    return contingencyTableCalculator->GetContingencyTable();
+    return contingencyTableCalculator->BuildContingencyTable();
   }
   
 

Modules/Learning/Unsupervised/include/otbContingencyTableCalculator.h

@@ -72,7 +72,7 @@ public:
   itkGetConstMacro(NumberOfSamples, unsigned long);
 
   void Clear();
-  ContingencyTableType GetContingencyTable();
+  ContingencyTableType BuildContingencyTable();
 
 protected:
   ContingencyTableCalculator();

Modules/Learning/Unsupervised/include/otbContingencyTableCalculator.txx

@@ -85,7 +85,7 @@ ContingencyTableCalculator<TClassLabel>
 template<class TClassLabel>
 typename ContingencyTableCalculator<TClassLabel>::ContingencyTableType
 ContingencyTableCalculator<TClassLabel>
-::GetContingencyTable()
+::BuildContingencyTable()
 {
   std::set<TClassLabel> refLabels;
   std::set<TClassLabel> prodLabels;

Modules/Learning/Unsupervised/test/otbContingencyTableCalculatorTest.cxx

@@ -126,7 +126,7 @@ int otbContingencyTableCalculatorCompute(int argc, char* argv[])
     }
 
   calculator->Compute( refLabels->Begin(), refLabels->End(), prodLabels->Begin(), prodLabels->End() );
-  ContingencyTableType confmat = calculator->GetContingencyTable();
+  ContingencyTableType confmat = calculator->BuildContingencyTable();
 
 
   if( static_cast<int>(calculator->GetNumberOfRefClasses()) != nbRefClasses )
@@ -216,7 +216,7 @@ int otbContingencyTableCalculatorComputeWithBaseline(int itkNotUsed(argc), char*
     }
 
   calculator->Compute( refLabels->Begin(), refLabels->End(), prodLabels->Begin(), prodLabels->End() );
-  CalculatorType::ContingencyTableType confmat = calculator->GetContingencyTable();
+  CalculatorType::ContingencyTableType confmat = calculator->BuildContingencyTable();
 
   std::cout << std::endl;
   std::cout << "contingency Table" << std::endl << confmat << std::endl;