BUG: use smart pointer to manage the default callback

Modules/Core/Common/include/otbStandardOneLineFilterWatcher.h

@@ -68,7 +68,7 @@ public:
   StandardOneLineFilterWatcher();
 
   /** Destrucotr */
-  virtual ~StandardOneLineFilterWatcher();
+  virtual ~StandardOneLineFilterWatcher() =default;
 
   /** Get/Set number of stars */
   void SetStars(int count)
@@ -115,7 +115,7 @@ private:
   
   /** A default callback created in the constructor and deleted in the 
    * destructor. */ 
-  PrintCallbackType * m_DefaultCallback;
+  std::shared_ptr<PrintCallbackType> m_DefaultCallback;
 };
 
 } // end namespace otb

Modules/Core/Common/include/otbStandardOneLineFilterWatcher.hxx

@@ -38,8 +38,8 @@ StandardOneLineFilterWatcher<PrintCallbackType>
     m_CurrentNbStars(-1),
     m_CoutIsConsole( System::IsInteractive(1) )
 {
-  m_DefaultCallback = new PrintCallbackType;
-  m_Callback = m_DefaultCallback;
+  m_DefaultCallback = std::make_shared<PrintCallbackType>() ;
+  m_Callback = m_DefaultCallback.get();
 }
 
 template<class PrintCallbackType>
@@ -51,8 +51,8 @@ StandardOneLineFilterWatcher<PrintCallbackType>
     m_CurrentNbStars(-1),
     m_CoutIsConsole( System::IsInteractive(1) )
 {
-  m_DefaultCallback = new PrintCallbackType;
-  m_Callback = m_DefaultCallback;
+  m_DefaultCallback = std::make_shared<PrintCallbackType>() ;
+  m_Callback = m_DefaultCallback.get();
 }
 
 template<class PrintCallbackType>
@@ -64,15 +64,8 @@ StandardOneLineFilterWatcher<PrintCallbackType>
     m_CurrentNbStars(-1),
     m_CoutIsConsole( System::IsInteractive(1) )
 {
-  m_DefaultCallback = new PrintCallbackType;
-  m_Callback = m_DefaultCallback;
-}
-
-template<class PrintCallbackType>
-StandardOneLineFilterWatcher<PrintCallbackType>
-::~StandardOneLineFilterWatcher()
-{
-  delete m_DefaultCallback;
+  m_DefaultCallback = std::make_shared<PrintCallbackType>() ;
+  m_Callback = m_DefaultCallback.get();
 }
 
 template<class PrintCallbackType>