WRG: fix ignored type qualifier warnings

Code/Common/otbSubsampledImageRegionConstIterator.h

@@ -222,7 +222,7 @@ public:
    * No Bound checking is performed when setting the position.
    */
   void SetOffset(const OffsetType& offset);
-  const OffsetType GetOffset() const
+  OffsetType GetOffset() const
   {
     return this->m_Offset;
   }

Code/FeatureExtraction/otbExtractSegmentsImageFilter.h

@@ -80,45 +80,45 @@ public:
 
   /** Set/Get the radius of the region of the pixel suppression by direction image filter. */
   void SetPixelSuppressionRadius(SizeType Radius);
-  const SizeType GetPixelSuppressionRadius(void);
+  const SizeType GetPixelSuppressionRadius();
 
   /** Set/Get Angular Accuracy on the direction of the central pixel for
       the pixel suppression by direction image filter. */
   void SetPixelSuppressionAngularBeam(float AngularBeam);
-  const float GetPixelSuppressionAngularBeam(void);
+  float GetPixelSuppressionAngularBeam();
 
   /** Set/Get the radius used to define the region of local hough filter. */
   void SetLocalHoughRadius(SizeType Radius);
-  const SizeType GetLocalHoughRadius(void);
+  const SizeType GetLocalHoughRadius();
 
   /** Set/Get the number of lines we are looking for in the local hough filter. */
   void SetLocalHoughNumberOfLines(unsigned int Radius);
-  const unsigned int GetLocalHoughNumberOfLines(void);
+  unsigned int GetLocalHoughNumberOfLines();
 
   /** Set/Get the radius of the disc to remove from the accumulator
    *  for each line found */
   void SetLocalHoughDiscRadius(float DiscRadius);
-  const float GetLocalHoughDiscRadius(void);
+  float GetLocalHoughDiscRadius();
 
   /** Set/Get the variance of the gaussian bluring for the accumulator */
   void SetLocalHoughVariance(float Variance);
-  const float GetLocalHoughVariance(void);
+  float GetLocalHoughVariance();
 
   /** Set/Get the radius between two segments in the fill gaps filter. */
   void SetFillGapsRadius(float Radius);
-  const float GetFillGapsRadius(void);
+  float GetFillGapsRadius();
 
   /** Set/Get Angular Beam between two segments in the fill gaps filter. */
   void SetFillGapsAngularBeam(float AngularBeam);
-  const float GetFillGapsAngularBeam(void);
+  float GetFillGapsAngularBeam();
 
   /** Set/Get the image input of this filter.  */
   void SetInputImage(const InputImageType *image);
-  const InputImageType * GetInputImage(void);
+  const InputImageType * GetInputImage();
 
   /** Set/Get the image direction of this filter.  */
   void SetInputImageDirection(const InputImageType *image);
-  const InputImageType * GetInputImageDirection(void);
+  const InputImageType * GetInputImageDirection();
 
   /** Set/Get the value of the drawed line*/
   itkGetMacro(LineValue, typename OutputImageType::PixelType);

Code/FeatureExtraction/otbExtractSegmentsImageFilter.txx

@@ -55,7 +55,7 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 template <class TInputImage, class TOutputImage>
 const typename ExtractSegmentsImageFilter<TInputImage, TOutputImage>::InputImageType *
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetInputImage(void)
+::GetInputImage()
 {
   return static_cast<const InputImageType *>
            (this->GetInput(0));
@@ -74,7 +74,7 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 template <class TInputImage, class TOutputImage>
 const typename ExtractSegmentsImageFilter<TInputImage, TOutputImage>::InputImageType *
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetInputImageDirection(void)
+::GetInputImageDirection()
 {
   return static_cast<const InputImageType *>
            (this->GetInput(1));
@@ -93,7 +93,7 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 template <class TInputImage, class TOutputImage>
 const typename ExtractSegmentsImageFilter<TInputImage, TOutputImage>::SizeType
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetPixelSuppressionRadius(void)
+::GetPixelSuppressionRadius()
 {
   return (m_PixelSuppression->GetRadius());
 }
@@ -106,9 +106,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const float
+float
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetPixelSuppressionAngularBeam(void)
+::GetPixelSuppressionAngularBeam()
 {
   return (m_PixelSuppression->GetAngularBeam());
 }
@@ -126,7 +126,7 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 template <class TInputImage, class TOutputImage>
 const typename ExtractSegmentsImageFilter<TInputImage, TOutputImage>::SizeType
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetLocalHoughRadius(void)
+::GetLocalHoughRadius()
 {
   return (m_LocalHough->GetRadius());
 }
@@ -139,9 +139,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const unsigned int
+unsigned int
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetLocalHoughNumberOfLines(void)
+::GetLocalHoughNumberOfLines()
 {
   return (m_LocalHough->GetNumberOfLines());
 }
@@ -154,9 +154,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const float
+float
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetLocalHoughDiscRadius(void)
+::GetLocalHoughDiscRadius()
 {
   return (m_LocalHough->GetDiscRadius());
 }
@@ -169,9 +169,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const float
+float
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetLocalHoughVariance(void)
+::GetLocalHoughVariance()
 {
   return (m_LocalHough->GetVariance());
 }
@@ -187,9 +187,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const float
+float
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetFillGapsRadius(void)
+::GetFillGapsRadius()
 {
   return (m_FillGaps->GetRadius());
 }
@@ -202,9 +202,9 @@ void ExtractSegmentsImageFilter<TInputImage, TOutputImage>
 }
 
 template <class TInputImage, class TOutputImage>
-const float
+float
 ExtractSegmentsImageFilter<TInputImage, TOutputImage>
-::GetFillGapsAngularBeam(void)
+::GetFillGapsAngularBeam()
 {
   return (m_FillGaps->GetAngularBeam());
 }

Code/FeatureExtraction/otbHaralickTexturesImageFunction.h

@@ -221,7 +221,7 @@ private:
   InputPixelType m_InputImageMaximum;
 
   //TODO: should we use constexpr? only c++11 and problem for msvc
-  const double GetPixelValueTolerance() const {return 0.0001; }
+  inline double GetPixelValueTolerance() const {return 0.0001; }
 
 };
 

Code/Segmentation/otbStreamingImageToOGRLayerSegmentationFilter.h

@@ -331,7 +331,7 @@ public:
      this->GetFilter()->SetUse8Connected(flag);
   }
 
-  const bool GetUse8Connected()
+  bool GetUse8Connected()
   {
      return this->GetFilter()->GetUse8Connected();
   }
@@ -341,7 +341,7 @@ public:
      this->GetFilter()->SetFilterSmallObject(flag);
   }
 
-  const bool GetFilterSmallObject()
+  bool GetFilterSmallObject()
   {
      return this->GetFilter()->GetFilterSmallObject();
   }
@@ -351,7 +351,7 @@ public:
      this->GetFilter()->SetMinimumObjectSize(size);
   }
 
-  const unsigned int GetMinimumObjectSize()
+  unsigned int GetMinimumObjectSize()
   {
      return this->GetFilter()->GetMinimumObjectSize();
   }
@@ -361,7 +361,7 @@ public:
      this->GetFilter()->SetSimplify(flag);
   }
 
-  const bool GetSimplify()
+  bool GetSimplify()
   {
      return this->GetFilter()->GetSimplify();
   }
@@ -373,7 +373,7 @@ public:
      this->GetFilter()->SetSimplificationTolerance(tol);
   }
 
-  const double GetSimplificationTolerance()
+  double GetSimplificationTolerance()
   {
      return this->GetFilter()->GetSimplificationTolerance();
   }