ENH: Ensure RAM parameter is used by persistent filters (should be applied likewise for all applications)

The "count-insert" idiom is an antipattern that leads to searching the
element twice. Avoid that and also the 0 comparison a bit below.

In addition, cache the end iterators of the two maps. This is safe as
the iterators stay valid when the map is modified.

TEST: Changing output data format to .img because gdal < 2.0 does not handle properly the AREA_OR_POINT georeferencing for tiff format

Bas Couwenberg authored 8 years ago and Rashad Kanavath committed 8 years ago

This patch is authored by Bas Couwenberg <sebastic@debian.org>

    Where available, use c++11 features to identify
    potential nullptr usage errors.

    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt

    find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'

        clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.

        build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.

        #Run clang modernize check using utility script which allow to process the code in parallel (only on Applications directory)
        python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/Modules/Applications/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/Applications/*/app/*.cxx  > ~/temporary/run-clang-tidy-app-log.txt

        #Replace override by ITK macro (to maintain compat with c++98) in Modules/Applications
        find . -type f -print -name "*.cxx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'