BUG: apply shellcheck to fix potential script issues

Packaging/Files/linux_pkgsetup.in

@@ -44,7 +44,7 @@ PATCH_ELF_EXE="$OUT_DIR/patchelf"
 #do not move below block. it must be before "unset LD_LIBRARY_PATH" code
 #check if we have any python bindings
 if [ -f "$OUT_DIR/lib/python/_otbApplication.so" ] ; then
-    chmod +x $OUT_DIR/setup_python.sh
+    chmod +x "$OUT_DIR/setup_python.sh"
     ./setup_python.sh || setup_python_ret=$?
 fi
 
@@ -52,7 +52,7 @@ fi
 unset LD_LIBRARY_PATH
 
 # we remove files in $OUT_DIR/lib/gtk which we CANNOT add new rpath
-BINARY_FILES=$(find $OUT_DIR/lib $OUT_DIR/bin -type f -exec file {} \; | grep -v '/lib/gtk/' | grep -i elf|cut -f1 -d':')
+BINARY_FILES=$(find "$OUT_DIR/lib" "$OUT_DIR/bin" -type f -exec file {} \; | grep -v '/lib/gtk/' | grep -i elf|cut -f1 -d':')
 # run patchelf
 for bin_file in $BINARY_FILES; do
     #echo "adding rpath to $bin_file"

Packaging/Files/macx_pkgsetup.in

@@ -41,7 +41,7 @@ OUT_DIR=$(pwd)
 
 #do not move below 3 lines. it must be before "unset LD_LIBRARY_PATH" code
 if [ -f "$OUT_DIR/lib/python/_otbApplication.so" ] ; then
-  chmod +x $OUT_DIR/setup_python.sh
+  chmod +x "$OUT_DIR/setup_python.sh"
   ./setup_python.sh || setup_python_ret=$?
 fi
 

Utilities/Maintenance/SuperbuildDownloadList.sh

@@ -45,7 +45,7 @@ if [[ "$GIT_BRANCH" =~ release-* ]]; then
 else
     VERSION="develop"
 fi
-CMAKE_FILES=$(find $SB_CMAKE_DIR -maxdepth 1 -type f -name "External_*")
+CMAKE_FILES=$(find "${SB_CMAKE_DIR}" -maxdepth 1 -type f -name "External_*")
 DOWNLOAD_LIST=$(grep -h -E '^[^#]*\"(ftp|http|https)://.*(\.tar\.gz|\.tar\.bz2|\.tgz|\.tar\.xz|\.zip|export=download).*\"' ${CMAKE_FILES} |
 		    grep -o -E '(ftp|http|https)://[^\"]*' | sort | uniq)