Skip to content
Snippets Groups Projects

Deprecate mapnik in 7.0

Merged Deprecate mapnik in 7.0
deprecate-mapnik into develop
All threads resolved!
Merged Guillaume Pasero requested to merge deprecate-mapnik into develop
All threads resolved!

Summary

This MR improves the handling of deprecated features, and also deprecate Mapnik related modules.

Rationale

See #1692 (closed).

Implementation Details

CMake build system
  • Improvements on the handling of deprecated modules. It is now possible to declare a whole module DEPRECATED.
  • If the option OTB_USE_DEPRECATED=OFF, this module will be disabled.
  • The modules export macros are now consistent (uppercase/lowercase). For instance OTBIOTileMapExport.h defines:
    • OTBIOTileMap_EXPORT
    • OTBIOTileMap_DEPRECATED
    • OTBIOTileMap_DEPRECATED_EXPORT
Classes and files
  • The Mapnik modules OTBMapnik and OTBVectorDataRendering are now deprecated
Documentation

Doxygen tags \deprecated have been added.

Additional notes

Copyright

The copyright owner is COPYRIGHT OWNER (OR OWNER'S AGENT) and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited by Guillaume Pasero

Merge request reports

Approval is optional

Merged by Antoine RegimbeauAntoine Regimbeau 6 years ago (Sep 19, 2018 8:00am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Guillaume Pasero changed the description

    changed the description

  • Guillaume Pasero resolved all discussions

    resolved all discussions

  • Victor Poughon resolved all discussions

    resolved all discussions

  • Guillaume Pasero mentioned in merge request !197 (closed)

    mentioned in merge request !197 (closed)

  • Julien Michel
    Julien Michel @jmichel ·
    Reporter

    I would say remove the whole thing, in accordance with #1716 (closed) . We already merged backward incompatible changes ...

  • Julien Michel
    Julien Michel @jmichel ·
    Reporter

    Why is this issue tagged as bug ?

  • Julien Michel closed

    closed

  • Julien Michel reopened

    reopened

  • Julien Michel resolved all discussions

    resolved all discussions

  • Antoine Regimbeau added api and removed bug labels

    added api and removed bug labels

  • Antoine Regimbeau merged

    merged

  • Antoine Regimbeau mentioned in merge request !244 (merged)

    mentioned in merge request !244 (merged)

  • Victor Poughon mentioned in issue #1704 (closed)

    mentioned in issue #1704 (closed)

  • Victor Poughon mentioned in issue #1682 (closed)

    mentioned in issue #1682 (closed)

  • Antoine Regimbeau mentioned in merge request !267 (closed)

    mentioned in merge request !267 (closed)

  • Cédric Traizet added refactoring label

    added refactoring label

    • Please register or sign in to reply