Skip to content

Remove false NCLS

Antoine Regimbeau requested to merge hyperspect_ncls into develop

Summary

As said in #1921 (closed) the NCLS filter we had was doing nothing more than the UCLS filter. That is why I removed it from the application choice and also from OTB.

Rationale

This filter was doing the same thing as an unconstrained least square. Have a look at the for loop here and replace all the matrix to see that correction=0

Documentation

No reference in documentation

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Merge request reports