Remove false NCLS

Summary

As said in #1921 (closed) the NCLS filter we had was doing nothing more than the UCLS filter. That is why I removed it from the application choice and also from OTB.

Rationale

This filter was doing the same thing as an unconstrained least square. Have a look at the for loop here and replace all the matrix to see that correction=0

Documentation

No reference in documentation

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Modules/Applications/AppHyperspectral/app/otbHyperspectralUnmixing.cxx

@@ -23,8 +23,6 @@
 
 #include "otbUnConstrainedLeastSquareImageFilter.h"
 #include "otbISRAUnmixingImageFilter.h"
-#include "otbNCLSUnmixingImageFilter.h"
-//#include "otbFCLSUnmixingImageFilter.h"
 #include "otbMDMDNMFImageFilter.h"
 
 
@@ -34,8 +32,6 @@ namespace Wrapper
 {
 typedef otb::UnConstrainedLeastSquareImageFilter<DoubleVectorImageType, DoubleVectorImageType, double> UCLSUnmixingFilterType;
 typedef otb::ISRAUnmixingImageFilter<DoubleVectorImageType, DoubleVectorImageType, double>             ISRAUnmixingFilterType;
-typedef otb::NCLSUnmixingImageFilter<DoubleVectorImageType, DoubleVectorImageType, double>             NCLSUnmixingFilterType;
-//typedef otb::FCLSUnmixingImageFilter<DoubleVectorImageType, DoubleVectorImageType, double>             FCLSUnmixingFilterType;
 typedef otb::MDMDNMFImageFilter<DoubleVectorImageType, DoubleVectorImageType>                          MDMDNMFUnmixingFilterType;
 
 typedef otb::VectorImageToMatrixImageFilter<DoubleVectorImageType> VectorImageToMatrixImageFilterType;
@@ -65,12 +61,12 @@ enum UnMixingMethod
 {
   UnMixingMethod_UCLS,
   //UnMixingMethod_FCLS,
-  UnMixingMethod_NCLS,
+  // UnMixingMethod_NCLS,
   UnMixingMethod_ISRA,
   UnMixingMethod_MDMDNMF,
 };
 
-const char* UnMixingMethodNames [] = { "UCLS", "FCLS", "NCLS", "ISRA", "MDMDNMF", };
+const char* UnMixingMethodNames [] = { "UCLS", "ISRA", "MDMDNMF", };
 
 
 class HyperspectralUnmixing : public Application
@@ -104,9 +100,7 @@ private:
     "be estimated using the VertexComponentAnalysis application.\n\n"
     "The application allows estimating the abundance maps with several algorithms:\n\n"
     "* Unconstrained Least Square (ucls)\n"
-//  "* Fully Constrained Least Square (fcls)\n"
     "* Image Space Reconstruction Algorithm (isra)\n"
-    "* Non-negative constrained\n"
     "* Least Square (ncls)\n"
     "* Minimum Dispersion Constrained Non Negative Matrix Factorization (MDMDNMF)."
     );
@@ -135,12 +129,6 @@ private:
     AddChoice("ua.ucls", "UCLS");
     SetParameterDescription("ua.ucls", "Unconstrained Least Square");
 
-//    AddChoice("ua.fcls", "FCLS");
-//    SetParameterDescription("ua.fcls", "Fully constrained Least Square");
-
-    AddChoice("ua.ncls", "NCLS");
-    SetParameterDescription("ua.ncls", "Non-negative constrained Least Square");
-
     AddChoice("ua.isra", "ISRA");
     SetParameterDescription("ua.isra", "Image Space Reconstruction Algorithm");
 
@@ -217,36 +205,6 @@ private:
 
       }
       break;
-    case UnMixingMethod_NCLS:
-      {
-      otbAppLogINFO("NCLS Unmixing");
-
-      NCLSUnmixingFilterType::Pointer unmixer =
-          NCLSUnmixingFilterType::New();
-
-      unmixer->SetInput(inputImage);
-      unmixer->GetModifiableFunctor().SetEndmembersMatrix(endMembersMatrix);
-      abundanceMap = unmixer->GetOutput();
-      m_ProcessObjects.push_back(unmixer.GetPointer());
-
-      }
-      break;
-      /*
-    case UnMixingMethod_FCLS:
-      {
-      otbAppLogINFO("FCLS Unmixing");
-
-      FCLSUnmixingFilterType::Pointer unmixer =
-          FCLSUnmixingFilterType::New();
-
-      unmixer->SetInput(inputImage);
-      unmixer->SetEndmembersMatrix(endMembersMatrix);
-      abundanceMap = unmixer->GetOutput();
-      m_ProcessObjects.push_back(unmixer.GetPointer());
-
-      }
-      break;
-      */
     case UnMixingMethod_MDMDNMF:
       {
       otbAppLogINFO("MDMD-NMF Unmixing");