Skip to content

Fix FindNumpy.cmake

Cédric Traizet requested to merge fix_find_numpy into release-8.0

Summary

the FindNumpy.cmake file packaged in OTB is broken when used with cmake 3.12 because te name of the Python executable variable has changed in CMake form PYTHON_EXECUTABLE to Python_EXECUTABLE. As a result, the script recompiling the Python bindings was not able to find Numpy (for example in Ubuntu 20 where the default is cmake 3.13.3)

This MR fixes this script to handle both cmake <3.12 and cmake >= 3.12

bug reported on this note

TODO; test the generated packages on Ubuntu 18 (cmake 3.10) and Ubuntu 20 (cmake 3.16)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Merge request reports