Resolve "Fix some warnings with gcc 7.3 and clang 5.0"

Closes #1546 (closed)

restored source branch 1546-fix-warnings-with-gcc-7-3-and-clang-5-0

added 3 commits

• ba586206 - WRG: bool literal returned from main
• 76febce9 - WRG: this 'if' clause does not guard
• 90652689 - WRG: this statement may fall through

Compare with previous version

added 1 commit

• c6bea05f - WRG: ifdef for pragma omp and include omp header file

Compare with previous version

added 1 commit

• 706a7b5a - WRG: lastVertex may be used uninitialized in this function

Compare with previous version

changed title from WIP: Resolve "Fix warnings with gcc 7.3 and clang 5.0" to WIP: Resolve "Fix some warnings with gcc 7.3 and clang 5.0"

assigned to @mgrizonnet

unmarked as a Work In Progress

added 2 commits

• 5ff77194 - 1 commit from branch develop
• d940d24c - Merge branch 'develop' into 1546-fix-warnings-with-gcc-7-3-and-clang-5-0

Compare with previous version

I've fixed some warnings related to gcc and clang in this branch

Do I need to register the branch to the list of feature branch?

Personally I don't think so, but our contribution rules say that you have to. One night of dashboard testing should be enough.

branch registered

dashboard is green and I've got enough vote. I'll sync with develop and merge it.

@gpasero : no problem for me to do a merge request and test all branches before merging. Is it clear in our contribution rules that all code should come from a merge request?

I think that there are still some commits (few indeed) which come directly in the develop branch. Should we do something about this?

In the CONTRIBUTING.md, it is quite clear (see the "Code Contribution" section). If I remember correctly, we also said that when develop branch is broken, it was simpler to just push the "COMP" fixes on develop directly. To a certain extent, I would consider WRG commits similar to COMP commits, but this is a point of view.

Maybe we can agree that only COMP commits that fix the dashboard can go directly to develop. All the others go to merge request.

ok thanks.

I've open an issue #1550 (closed) to do this.

added 19 commits

• d940d24c...a76640a9 - 18 commits from branch develop
• e26410cf - Merge branch 'develop' into 1546-fix-warnings-with-gcc-7-3-and-clang-5-0

Compare with previous version

mentioned in commit 709a78ce

merged

mentioned in issue #1550 (closed)