C++ overall quality improvement

Correct code according to cppcheck report and correct code form according to sonar report.

# Priority

• Avoid shadow variable declaration
• Avoid truncated value cast
• Rewrite confusing if code
• Use var instead of magic number

# Other

• Add comments
• Remove dead code (commented or unused)
• Unify tab and space indentation. Please use space, tab indentation is awful and should be left to 20th century

All analysis are joint to this issue 2024-10-15-DIAPOTB-C-analysis-report.docx

2024-10-15-DIAPOTB-C-issues-report.xlsx

cppcheck_report.xml