CMAKE: set compile defs with set_target_properties

Modules/ThirdParty/OssimPlugins/src/CMakeLists.txt

@@ -29,28 +29,6 @@ configure_file(${CMAKE_CURRENT_SOURCE_DIR}/ossim/ossimplugins-config.h.in
     ${CMAKE_CURRENT_BINARY_DIR}/ossim/ossimplugins-config.h)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/ossim)
 
-# include_directories(${CMAKE_CURRENT_SOURCE_DIR}
-#   ${CMAKE_CURRENT_SOURCE_DIR}/ossim
-# #  ${OTB_SOURCE_DIR}/Utilities/otbossim/include
-# #  ${OTB_BINARY_DIR}/Utilities/otbossim/include
-# )
-#if(OTB_USE_EXTERNAL_OSSIM)
-#  include_directories(${OSSIM_INCLUDE_DIR})
-
-  # When using External ossim, compile ossimplugin as a DLL
-  # even if we compile OTB as a static lib
-  set(ossimplugins_LIBTYPE SHARED)
-  if(WIN32)
-    add_definitions(-DOSSIMPLUGINSMAKINGDLL)
-  endif()
-
-#else()
-#  include_directories(${OTB_SOURCE_DIR}/Utilities/otbossim/include)
-#  include_directories(${OTB_BINARY_DIR}/Utilities/otbossim/include)
-#endif()
-
-#include_directories(AFTER ${GEOTIFF_INCLUDE_DIRS} ${TIFF_INCLUDE_DIRS})
-
 include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/gdal)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/ossim)
@@ -59,14 +37,18 @@ file(GLOB_RECURSE ossimplugins_gdal_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/gdal/*.cpp
 file(GLOB_RECURSE ossimplugins_ossim_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/ossim/*.cpp")
 
 if(NOT WIN32)
-list(REMOVE_ITEM ossimplugins_ossim_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/ossim/ossimWin32FindFileHandle.cpp")
+  list(REMOVE_ITEM
+    ossimplugins_ossim_SRCS
+    "${CMAKE_CURRENT_SOURCE_DIR}/ossim/ossimWin32FindFileHandle.cpp"
+    )
 endif()
+
 set(ossimplugins_SOURCES
   ${ossimplugins_gdal_SRCS}
   ${ossimplugins_ossim_SRCS}
 )
 
-add_library(otbossimplugins ${ossimplugins_LIBTYPE} ${ossimplugins_SOURCES})
+add_library(otbossimplugins SHARED ${ossimplugins_SOURCES})
 target_link_libraries(otbossimplugins
   ${OTBBoost_LIBRARIES}
   ${OTBGDAL_LIBRARIES}
@@ -79,6 +61,12 @@ if(OTB_LIBRARY_PROPERTIES)
   set_target_properties(otbossimplugins PROPERTIES ${OTB_LIBRARY_PROPERTIES})
 endif(OTB_LIBRARY_PROPERTIES)
 
+if(MSVC)
+  set_target_properties(otbossimplugins PROPERTIES COMPILE_FLAGS "/DOSSIMPLUGINSMAKINGDLL")
+elseif(MINGW)
+  set_target_properties(otbossimplugins PROPERTIES COMPILE_FLAGS "-DOSSIMPLUGINSMAKINGDLL")
+endif()
+
 install(TARGETS otbossimplugins
   EXPORT ${OTB3P_INSTALL_EXPORT_NAME}
   RUNTIME DESTINATION ${OTB3P_INSTALL_RUNTIME_DIR} COMPONENT RuntimeLibraries