STY: Change ITK_OVERRIDE for override in whole code (find Modules -type f -exec sed -i 's/ITK_OVERRIDE/override/g' {} +)

BUG : as image now have an unsigned spacing and a signed direction, we need to set spacing AND direction parameters if using itk filter, here we use the itk gradient filter

Add ITK_OVERRIDE msotly in Monteverdi

save override in OTB (need to manually fix this after tidy)
  cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt
  cd ~/software
  python run-clang-tidy.py -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt
  #rename override with ITK macro ITK_OVERRIDE
  cd src/Modules
  find . -path ./ThirdParty -prune -o -type f -print -name "*.h" -o -name "*.txx" | xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'

Bas Couwenberg authored 8 years ago and Rashad Kanavath committed 8 years ago

This patch is authored by Bas Couwenberg <sebastic@debian.org>

    Where available, use c++11 features to identify
    potential nullptr usage errors.

    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt

    find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'

Used the following command:

find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

    clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.

    build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.

    #Save override occurences in otb code
    cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt

    #Run clang modernize check using utility script which allow to process the code in parallel
    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt

    #Replace override by ITK macro (to maintain compat with c++98)
    find . -type f -print -name "*.h" -o -name "*.txx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'

This is a big one without much harm. It fixes incorrect spelling
and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
Most of these changes are done by developers at DebianGIS.
For more info, I include the original patch header below.
Description: Fix some spelling errors to silence lintian
enabling  to concentrate on the real problem.
Author: Andreas Tille <tille@debian.org>
Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
Author: Bas Couwenberg <sebastic@xs4all.nl>
Last-Update: 2015-12-22

Following remarks from debian packagers, the ITCopyright.txt was mentioned in
several files but not available in the Copyright directory.  After contacting
the contributor Gregoire Mercier, he has suggested to harmonize the copyright for his
contributions.  Files with GET or IT copyright referenced now the
IMTCopyright.txt file (Institut Mines Telecom) which was added to the Copyright directory.

Moreover, Gregoire Mercier confirmed that he is not the author of 7 files which
are mentioning the GET or IT copyright:

Modules/Filtering/Projection/include/otbROIdataConversion.h
Modules/Filtering/Projection/include/otbROIdataConversion.txx
Modules/Segmentation/Conversion/test/otbVectorDataRasterizeFilter.cxx
Modules/Segmentation/Conversion/test/otbVectorDataToLabelImageFilterWithoutReader.cxx
Modules/Segmentation/Conversion/test/otbPolygonizationRasterizationTest.cxx
Modules/Segmentation/Conversion/test/otbVectorDataToLabelImageFilter.cxx
Modules/Segmentation/Conversion/test/otbOGRDataSourceToLabelImageFilter.cxx

Thus, the copyright was also modified for these 7 files (CNES Copyright).