STY: Change ITK_OVERRIDE for override in whole code (find Modules -type f -exec sed -i 's/ITK_OVERRIDE/override/g' {} +)

 Label is needed to perform mean shift segmentation but ModeSearch
 (needed to output label) was default set to false.

Change typedef to use otbWrapperTypes ones.
AddProcess for the applications.
Add progress Report for otbGeodesicMorphology* filters
Add documentation limits.
Remove unnecessary include and Update* call.

Bas Couwenberg authored 8 years ago and Rashad Kanavath committed 8 years ago

This patch is authored by Bas Couwenberg <sebastic@debian.org>

    Where available, use c++11 features to identify
    potential nullptr usage errors.

    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-nullptr -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Modules/*/*/app/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-nullptr-log.txt

    find . -type f -print -name "*.h" -o -name "*.txx" -o -name "*.cxx" |xargs perl -pi -e 's/nullptr/ITK_NULLPTR/g'

Used the following command:

find . \( -iname *.txx -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_txx/otb$1_txx/g;' {} \;
find . \( -iname *.h -and ! -path *ThirdParty* \) -exec perl -pi -w -e 's/__otb(.*)_h/otb$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

    clang-tidy tool can insert missing override keyword as a macro so that missing [optional] virtual identifiers can be easily added.

    build otb with clang 3.8 and use cmake option CMAKE_EXPORT_COMPILE_COMMANDS=ON. Most modules and third parties have been activated.

    #Save override occurences in otb code
    cd src/Modules ; grep -nR "override" * > ~/temporary/override_otb.txt

    #Run clang modernize check using utility script which allow to process the code in parallel
    python run-clang-tidy.py -clang-tidy-binary ~/software/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang-tidy -checks=-*,modernize-use-override -header-filter=/home/grizonnetm/projets/otb/src/OTB/Modules/.*/.*/include/.* -j8 -fix -p ~/projets/otb/bin/release/OTB-clang3.8/ ~/projets/otb/src/OTB/Modules/*/*/src/*.cxx ~/projets/otb/src/OTB/Examples/*/*.cxx ~/projets/otb/src/OTB/Modules/*/*/test/*.cxx > ~/temporary/run-clang-tidy-log.txt

    #Replace override by ITK macro (to maintain compat with c++98)
    find . -type f -print -name "*.h" -o -name "*.txx" |xargs perl -pi -e 's/\ override/\ ITK_OVERRIDE/g'

This patch is authored by Bas Couwenberg <sebastic@xs4all.nl>
from DebianGIS team. spelling errors were encountered when
updating OTB debian package for 5.2.1.
https://bugs.orfeo-toolbox.org/view.php?id=1143

This is a big one without much harm. It fixes incorrect spelling
and grammer when packaging OTB 5.0.0 and 5.2.0 for Debian.
Most of these changes are done by developers at DebianGIS.
For more info, I include the original patch header below.
Description: Fix some spelling errors to silence lintian
enabling  to concentrate on the real problem.
Author: Andreas Tille <tille@debian.org>
Author: Rashad Kanavath <rashad.kanavath@c-s.fr>
Author: Bas Couwenberg <sebastic@xs4all.nl>
Last-Update: 2015-12-22

itkStaticConstMacro has some modification in ITK 4.9+
as a result of VLV performance enhancements. This gives
link errors in 3rdParty trunk which use ITK 4.9. Using
enum directly gives more clarity and was an easy fix.