Skip to content
Snippets Groups Projects
New look: Off

Assertion error on Sentinel1 product in debug build

    • Closed Issue created by Victor Poughon @poughov

    Description

    Assertion error when reading Sentinel 1 product:

    ~/build/otb-develop-debug $ ./bin/otbcli_DynamicConvert -in ~/Downloads/S1A_IW_GRDH_1SDV_20181216T110608_20181216T110633_025050_02C38F_BAB0.SAFE/measurement/s1a-iw-grd-vh-20181216t110608-20181216t110633-025050-02c38f-002.tiff -out ~/Downloads/out.tif
otbApplicationLauncherCommandLine: /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1117: void ossimplugins::ossimSentinel1Model::readCoordinates(const ossimXmlNode&, const ossimString&, const ossimString&, const string&): Assertion `pos >= sizeof(SR_PREFIX)+4 && pos < sizeof(prefix)' failed.
Aborted (core dumped)

    Happens in this part of the code: https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/blob/develop/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp#L1117

    Steps to reproduce

    See example command above.

    Configuration information

    Ubuntu 18.04, OTB develop debug build.

    Designs

      Child items ...

      2. Activity

      • Victor Poughon added bug label

        added bug label

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor

        @lhermitte are you familiar with this part of the code?

      • Luc Hermitte
        Luc Hermitte @lhermitte ·
        Contributor

        @poughov Yes I am. git blame should point toward me I guess.

        The idea is that stringification is done with wanabe-safe C functions. In order to avoid overflows, a portable snprintf is provided. Then the assertion checks that we were able to fully generate the string in the destination static-buffer.

        Have you ran the command in gbd or analysed to core dumped? What are the values of pos, of sr_gr_prefix and of idx?

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor 
        (gdb) up
#4  0x00007fffee97d0ad in ossimplugins::ossimSentinel1Model::readCoordinates (this=0x5555555b36e0, node=..., rg0_xpath=..., coeffs_xpath=..., sr_gr_prefix="support_data.geom.srd.coords.sr")
    at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1117
1117	         assert(pos >= sizeof(SR_PREFIX)+4 && pos < sizeof(prefix));
(gdb) print pos
$1 = 35
(gdb) print sr_gr_prefix
$2 = "support_data.geom.srd.coords.sr"
(gdb) print idx
$3 = 0
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff7431801 in __GI_abort () at abort.c:79
#2  0x00007ffff742139a in __assert_fail_base (fmt=0x7ffff75a87d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7fffee9e5898 "pos >= sizeof(SR_PREFIX)+4 && pos < sizeof(prefix)", 
    file=file@entry=0x7fffee9e4f50 "/home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp", line=line@entry=1117, 
    function=function@entry=0x7fffee9e5f60 <ossimplugins::ossimSentinel1Model::readCoordinates(ossimXmlNode const&, ossimString const&, ossimString const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::__PRETTY_FUNCTION__> "void ossimplugins::ossimSentinel1Model::readCoordinates(const ossimXmlNode&, const ossimString&, const ossimString&, const string&)") at assert.c:92
#3  0x00007ffff7421412 in __GI___assert_fail (assertion=0x7fffee9e5898 "pos >= sizeof(SR_PREFIX)+4 && pos < sizeof(prefix)", 
    file=0x7fffee9e4f50 "/home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp", line=1117, 
    function=0x7fffee9e5f60 <ossimplugins::ossimSentinel1Model::readCoordinates(ossimXmlNode const&, ossimString const&, ossimString const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::__PRETTY_FUNCTION__> "void ossimplugins::ossimSentinel1Model::readCoordinates(const ossimXmlNode&, const ossimString&, const ossimString&, const string&)") at assert.c:101
#4  0x00007fffee97d0ad in ossimplugins::ossimSentinel1Model::readCoordinates (this=0x5555555b36e0, node=..., rg0_xpath=..., coeffs_xpath=..., sr_gr_prefix="support_data.geom.srd.coords.sr")
    at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1117
#5  0x00007fffee97ce6a in ossimplugins::ossimSentinel1Model::addSRGRCoefficients (this=0x5555555b36e0, coordinateConversionList=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1098
#6  0x00007fffee978bd5 in ossimplugins::ossimSentinel1Model::read (this=0x5555555b36e0, annotationXml=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:792
#7  0x00007fffee976d3e in ossimplugins::ossimSentinel1Model::readProduct (this=0x5555555b36e0, productXmlFile=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:629
#8  0x00007fffee974928 in ossimplugins::ossimSentinel1Model::open (this=0x5555555b36e0, file=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:273
#9  0x00007fffee93de03 in ossimplugins::doBuildProjection<ossimplugins::ossimSentinel1Model> (filename=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimPluginProjectionFactory.cpp:128
#10 0x00007fffee93b467 in ossimplugins::ossimPluginProjectionFactory::createProjection (this=0x7fffeea4a810 <ossimplugins::ossimPluginProjectionFactory::factoryInstance>, file_name=...)
    at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimPluginProjectionFactory.cpp:173
#11 0x00007ffff262c5bf in otb::ReadGeometryFromImage (
    filename="/home/poughov/Downloads/S1A_IW_GRDH_1SDV_20181216T110608_20181216T110633_025050_02C38F_BAB0.SAFE/measurement/s1a-iw-grd-vh-20181216t110608-20181216t110633-025050-02c38f-002.tiff", checkRpcTag=true)
    at /home/poughov/cnes/dev/otb/Modules/Adapters/OSSIMAdapters/src/otbImageKeywordlist.cxx:240
#12 0x00007ffff4c3fb1d in otb::ImageFileReader<otb::VectorImage<float, 2u>, otb::DefaultConvertPixelTraits<float> >::GenerateOutputInformation (this=0x5555555aa200)
    at /home/poughov/cnes/dev/otb/Modules/IO/ImageIO/include/otbImageFileReader.hxx:429
#13 0x00007ffff7ebe68d in itk::ProcessObject::UpdateOutputInformation() () from /home/poughov/build/SuperBuild-depends/install/lib/libITKCommon-4.13.so.1
#14 0x00007ffff673e69e in otb::Wrapper::InputImageParameter::GetImage<otb::VectorImage<float, 2u> > (this=0x5555555a6aa0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/include/otbWrapperInputImageParameter.hxx:59
#15 0x00007ffff6cd8973 in otb::Wrapper::Application::GetParameterImage<otb::VectorImage<float, 2u> > (this=0x5555555a5aa0, parameter="in")
    at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/include/otbWrapperApplication.h:860
#16 0x00007ffff6cd175a in otb::Wrapper::Application::GetParameterImage (this=0x5555555a5aa0, parameter="in") at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/src/otbWrapperApplication.cxx:1184
#17 0x00007fffecdbda53 in otb::Wrapper::DynamicConvert::DoUpdateParameters (this=0x5555555a5aa0) at /home/poughov/cnes/dev/otb/Modules/Applications/AppImageUtils/app/otbDynamicConvert.cxx:209
#18 0x00007ffff6ccbbb7 in otb::Wrapper::Application::UpdateParameters (this=0x5555555a5aa0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/src/otbWrapperApplication.cxx:450
#19 0x00007ffff7fd99a1 in otb::Wrapper::CommandLineLauncher::LoadParameters (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:475
#20 0x00007ffff7fd8443 in otb::Wrapper::CommandLineLauncher::BeforeExecute (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:272
#21 0x00007ffff7fd7338 in otb::Wrapper::CommandLineLauncher::ExecuteAndWriteOutputNoCatch (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:140
#22 0x00007ffff7fd7447 in otb::Wrapper::CommandLineLauncher::ExecuteAndWriteOutput (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:166
#23 0x000055555555d3cc in main (argc=7, argv=0x7fffffffe1c8) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbApplicationLauncherCommandLine.cxx:311
(gdb)
      • Luc Hermitte
        Luc Hermitte @lhermitte ·
        Contributor

        It seems the assertion has been written with the assumption that SR_PREFIX was a char const[N], but it's actually a std::string. We should replace all the sizeof(SR_PREFIX) (and other keys from "ossimSarSensorModelPathsAndKeys.h) with SR_PREFIX.size().

        It looks like the incorrect assertion has been there for quite some time. Sorry ^^'

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor

        I just tried that replacement: https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/compare/develop...1874-fix-s1-assert

        and now it fails somewhere else (line 1156 of the above diff)

        (gdb) up
#2  0x00007ffff7421412 in __GI___assert_fail (assertion=0x7fffee9ee9e8 "pos >= SR_PREFIX.size()+4 && pos < 1024", file=0x7fffee9edf90 "/home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp", 
    line=1156, function=0x7fffee9ef040 <ossimplugins::ossimSentinel1Model::readGeoLocationGrid(ossimXmlNode const&)::__PRETTY_FUNCTION__> "void ossimplugins::ossimSentinel1Model::readGeoLocationGrid(const ossimXmlNode&)") at assert.c:101
101	in assert.c
(gdb) print pos
No symbol "pos" in current context.
(gdb) up
#3  0x00007fffee986828 in ossimplugins::ossimSentinel1Model::readGeoLocationGrid (this=0x5555555b3f90, productRoot=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1156
1156	         assert(pos >= SR_PREFIX.size()+4 && pos < 1024);
(gdb) print pos
$1 = 25
(gdb) print SR_PREFIX
$2 = "support_data.geom.srd.coords.sr"
(gdb) print sr_gr_prefix
No symbol "sr_gr_prefix" in current context.
(gdb) SR_PREFIX.size()
Undefined command: "SR_PREFIX".  Try "help".
(gdb) print SR_PREFIX.size()
$3 = 31
(gdb) print pos
$4 = 25
(gdb) bt
#0  __GI_abort () at abort.c:49
#1  0x00007ffff742139a in __assert_fail_base (fmt=0x7ffff75a87d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7fffee9ee9e8 "pos >= SR_PREFIX.size()+4 && pos < 1024", 
    file=file@entry=0x7fffee9edf90 "/home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp", line=line@entry=1156, 
    function=function@entry=0x7fffee9ef040 <ossimplugins::ossimSentinel1Model::readGeoLocationGrid(ossimXmlNode const&)::__PRETTY_FUNCTION__> "void ossimplugins::ossimSentinel1Model::readGeoLocationGrid(const ossimXmlNode&)")
    at assert.c:92
#2  0x00007ffff7421412 in __GI___assert_fail (assertion=0x7fffee9ee9e8 "pos >= SR_PREFIX.size()+4 && pos < 1024", file=0x7fffee9edf90 "/home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp", 
    line=1156, function=0x7fffee9ef040 <ossimplugins::ossimSentinel1Model::readGeoLocationGrid(ossimXmlNode const&)::__PRETTY_FUNCTION__> "void ossimplugins::ossimSentinel1Model::readGeoLocationGrid(const ossimXmlNode&)") at assert.c:101
#3  0x00007fffee986828 in ossimplugins::ossimSentinel1Model::readGeoLocationGrid (this=0x5555555b3f90, productRoot=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:1156
#4  0x00007fffee981d93 in ossimplugins::ossimSentinel1Model::read (this=0x5555555b3f90, annotationXml=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:815
#5  0x00007fffee97fd3e in ossimplugins::ossimSentinel1Model::readProduct (this=0x5555555b3f90, productXmlFile=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:629
#6  0x00007fffee97d928 in ossimplugins::ossimSentinel1Model::open (this=0x5555555b3f90, file=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSentinel1Model.cpp:273
#7  0x00007fffee946e03 in ossimplugins::doBuildProjection<ossimplugins::ossimSentinel1Model> (filename=...) at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimPluginProjectionFactory.cpp:128
#8  0x00007fffee944467 in ossimplugins::ossimPluginProjectionFactory::createProjection (this=0x7fffeea53810 <ossimplugins::ossimPluginProjectionFactory::factoryInstance>, file_name=...)
    at /home/poughov/cnes/dev/otb/Modules/ThirdParty/OssimPlugins/src/ossim/ossimPluginProjectionFactory.cpp:173
#9  0x00007ffff25984ef in otb::ReadGeometryFromImage (
    filename="/home/poughov/Downloads/S1A_IW_GRDH_1SDV_20181216T110608_20181216T110633_025050_02C38F_BAB0.SAFE/measurement/s1a-iw-grd-vh-20181216t110608-20181216t110633-025050-02c38f-002.tiff", checkRpcTag=true)
    at /home/poughov/cnes/dev/otb/Modules/Adapters/OSSIMAdapters/src/otbImageKeywordlist.cxx:240
#10 0x00007ffff4c46b1d in otb::ImageFileReader<otb::VectorImage<float, 2u>, otb::DefaultConvertPixelTraits<float> >::GenerateOutputInformation (this=0x5555555aa0e0)
    at /home/poughov/cnes/dev/otb/Modules/IO/ImageIO/include/otbImageFileReader.hxx:429
#11 0x00007ffff7ebe68d in itk::ProcessObject::UpdateOutputInformation() () from /home/poughov/build/SuperBuild-depends/install/lib/libITKCommon-4.13.so.1
#12 0x00007ffff674263e in otb::Wrapper::InputImageParameter::GetImage<otb::VectorImage<float, 2u> > (this=0x5555555a6d90) at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/include/otbWrapperInputImageParameter.hxx:59
#13 0x00007ffff6cda2a1 in otb::Wrapper::Application::GetParameterImage<otb::VectorImage<float, 2u> > (this=0x5555555a5e20, parameter="in")
    at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/include/otbWrapperApplication.h:860
#14 0x00007ffff6cd3088 in otb::Wrapper::Application::GetParameterImage (this=0x5555555a5e20, parameter="in") at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/src/otbWrapperApplication.cxx:1184
#15 0x00007fffecdc6a53 in otb::Wrapper::DynamicConvert::DoUpdateParameters (this=0x5555555a5e20) at /home/poughov/cnes/dev/otb/Modules/Applications/AppImageUtils/app/otbDynamicConvert.cxx:209
#16 0x00007ffff6ccd4e5 in otb::Wrapper::Application::UpdateParameters (this=0x5555555a5e20) at /home/poughov/cnes/dev/otb/Modules/Wrappers/ApplicationEngine/src/otbWrapperApplication.cxx:450
#17 0x00007ffff7fd99a1 in otb::Wrapper::CommandLineLauncher::LoadParameters (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:475
#18 0x00007ffff7fd8443 in otb::Wrapper::CommandLineLauncher::BeforeExecute (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:272
#19 0x00007ffff7fd7338 in otb::Wrapper::CommandLineLauncher::ExecuteAndWriteOutputNoCatch (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:140
#20 0x00007ffff7fd7447 in otb::Wrapper::CommandLineLauncher::ExecuteAndWriteOutput (this=0x5555555a2bc0) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbWrapperCommandLineLauncher.cxx:166
#21 0x000055555555d3cc in main (argc=7, argv=0x7fffffffe1c8) at /home/poughov/cnes/dev/otb/Modules/Wrappers/CommandLine/src/otbApplicationLauncherCommandLine.cxx:311
(gdb)
      • Luc Hermitte
        Luc Hermitte @lhermitte ·
        Contributor

        It should be pos >= GCP_PREFIX.size()+4 && pos < sizeof(prefix).

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor

        yeah that works. Now it's failing on this other assertion: https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/blob/develop/Modules/ThirdParty/OssimPlugins/src/ossim/ossimSarSensorModel.cpp#L1271

      • Victor Poughon mentioned in issue #1876

        mentioned in issue #1876

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor

        You're welcome to push fixes directly to the branch https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/compare/develop...1874-fix-s1-assert

      • Julien Michel changed milestone to %7.0.0

        changed milestone to %7.0.0

      • Julien Michel added CNES backlog label

        added CNES backlog label

      • Julien Michel removed CNES backlog label

        removed CNES backlog label

      • Julien Michel assigned to @poughov

        assigned to @poughov

      • Victor Poughon
        Victor Poughon @poughov ·
        Author Contributor

        There are two more assertions that need to be fixed:

        @lhermitte do you have time to take a look? Otherwise I will just remove them.

      • Luc Hermitte
        Luc Hermitte @lhermitte ·
        Contributor

        Sorry, I'm currently struggling with optimizing FFTW usage on complex images... In the mean time, you can replace the first sizeof with 0 I guess.

      • Victor Poughon mentioned in merge request !478 (merged)

        mentioned in merge request !478 (merged)

      • Victor Poughon closed via merge request !478 (merged)

        closed via merge request !478 (merged)

      • Victor Poughon mentioned in commit 57b0a16e

        mentioned in commit 57b0a16e

      Please register or sign in to reply