Remove Ossim based classes
This issue is part of the Ossim removal refactoring story (#1506 (closed))
Rationale
Once the new SAR model (without OSSIM) is in place and used by OTB, we need to clean the codebase by removing the classes related to OSSIM's SAR model.
Analysis
Tasks:
-
Remove OssimAdapters::TimeUtilities -
Refactor GeocentricTransform and remove EllipsoidAdapter -
Use ImageMetadata instead of ImageMetadataInterface to get metadata from images -
Missing metadata: -
DefaultDisplay -
EnhancedBandName (for Monteverdi), WIP -
Instrument is missing for a few sensors (this is used in OpticalCalibration logs) -
First and Last wavelength (band metadata) is missing for many sensors, but in a lot of case, I don't think the values are even correct in the old framework, and this metadata is not used anyway. It could be simply removed IMO
-
-
in Monteverdi -
in OTB except otb::Image and otb::VectorImage -
in otb::Image and otb::VectorImage
-
-
Make OTBMetadata independent of Ossim (mainly remove kwl usage in the XXXImageMetadataInterface classes) -
Remove remaining usages of kwl in the library to make all modules independent of OssimAdapters -
in Ice (The new Transform framework is not used there at the moment ...) -
Some transform tests have been replaced and should be removed -
don't read kwl in ImageFileWriter, don't write it in ImageFileWriter
-
-
Remove ImageKeywordList (OssimAdapters), OssimDEMHandler (OssimAdapters) SensorModelAdapter (OTBTransform) and SarSensorModelAdapter (OTBTransform) -
Remove ThirdParty::OssimPlugins -
Remove ThirdParty::Ossim -
Remove Ossim from Superbuild
Acceptance criterions
-
The CI is green even without the OSSIM code. -
The documentation is up to date.
Risk management
Risk | Likelihood | Impact | Action |
---|---|---|---|
some classes are missing in the list above | possible | additional task | remove it |
Edited by Julien Osman