TerraSar-X noise removal does not work as expected

SARCalibration has a boolean parameter noise that can be used to take into account the noise contribution to the signal. This parameter is only used for TerraSAR-X products

Setting this parameter to true actually deactivate noise compensation, which is a bit weird in my opinion. The SAR recipe is actually wrong when this parameter is introduced: https://www.orfeo-toolbox.org/CookBook-develop/recipes/sarprocessing.html#calibration

I don't think this parameter works as expected, in fact, SARCalibration of TerraSar-X products with noise=true seems to always lead to a black image (there is no hyperparameter to set, everything should be automatic). Maybe something is wrong in the implementation. I didn't find a reference in the code source, but the algorithm implemented in probably the one described in this document

This actually not tested. There is no TerraSAR test for the application. There are several test for SarRadiometricCalibrationToImageFilter, the associated filter, but none of them use the noise parameter. I think this was not intended, because some test specifically deactivate the noise parameter, while other use the default value (false).

Update 08/11/21: The noise parameter has been renamed to remove_noise. The problem with TerraSAR-X noise removal remains. The issue has been renamed accordingly