Missing quotes in otbenv.profile

Description

With the binaries package for OTB 9.1.0 from https://www.orfeo-toolbox.org/packages/OTB-9.1.0-Linux.tar.gz.

If lsb-release package is not installed on the system the following errors appear:

/otb-9.1.0/otbenv.profile: line 40: lsb_release: command not found
/otb-9.1.0/otbenv.profile: line 45: [: =: unary operator expected
/otb-9.1.0/otbenv.profile: line 45: [: =: unary operator expected
/otb-9.1.0/otbenv.profile: line 45: [: =: unary operator expected
/otb-9.1.0/otbenv.profile: line 65: [: =: unary operator expected
/otb-9.1.0/otbenv.profile: line 65: [: =: unary operator expected
/otb-9.1.0/otbenv.profile: line 65: [: =: unary operator expected

These errors can be avoid by putting $OS variable between quotes "$OS"

Steps to reproduce

Download the package, extract and run command source otbenv.profile on a system without lsb-release

Configuration information

Ubuntu 24.04 from dockerhub, OTB 9.1.0 , binaries

Hi @tardyb , the problem will be fixed in next version. One other problem when using docker is that lsb_release is not preinstalled. Thus the $OS variable is empty on docker. One temporary fix is to use:

sed -i "s/\$(lsb_release -is)/Ubuntu/g" $OTB_INSTALL_DIR/otbenv.profile
sed -i "s/\$(lsb_release -is)/Ubuntu/g" $OTB_INSTALL_DIR/tools/post_install.sh

mentioned in merge request !1054 (merged)

mentioned in commit 34c96ef5

closed with merge request !1054 (merged)

mentioned in issue #2456 (closed)

changed milestone to %9.1.1

added bug packaging labels