OTB binaries released on GitLab must be released under GNU GPL v2.0, not Apache v2.0

I've just taken a look at the binary archives for OTB version 9.0:

• https://www.orfeo-toolbox.org/packages/archives/OTB/OTB-9.1.0-Linux.tar.gz
• https://www.orfeo-toolbox.org/packages/archives/OTB/OTB-9.1.0-Linux_RedHat.tar.gz

It appears that the OTB binary archives published on GitLab include the FFTW3 libraries, and that the OTB binaries are linked to FFTW3 via the ITK libraries.

As the FFTW3 library is released under the GNU GPL v2.0 or higher, the OTB binaries are also released under the GNU GPL v2.0 license, and not under the Apache 2.0 license provided in the archive.

[Edit 13/03]

Definition of Done

• FFTW compilation is disabled by default
• FFTW test are disabled by default
• One CI job should at least test FFTW tests
• FFTW is not packaged in "All-in-one" package and in "Dependencies" package: no more fftw in lib, lib/cmake, include and bin

mentioned in merge request !1060 (merged)

To avoid the GPL contamination inside OTB, do not compile ITK with FFTW. Instead let the fftw compilation disabled by defaut and if the user want to compile with it, inform it with a cmake message that the otb compiled relies on GNU GPL v2 license instead of Apache 2.

So by default:

• skip the fftw downloading and compilation
• do not use ITK fftw options
• do not compile and add OverlapSaveConvolutionImageFilter inside the package
• Do not compile tests relying on OverlapSaveConvolutionImageFilter

Add cmake option OTB_USE_FFTW=ON which change the behavior to the actual one (compilation of fftw) and emit a message explaining the license change.

Also, is it possible to update v9.1 released binaries without waiting v10 release?

(v10 is likely to break a few things -- as implied by the fact this is a new major version)

mentioned in issue s1-tiling/s1tiling-dockers#8 (closed)

mentioned in issue #2456 (closed)

Solution found:

• option OTB_USE_FFTW enable the compilation with FFTW. By default this option is disabled
• In CI:
  • fftw is disabled in "prepare" jobs. Like this the FFTW will not be compiled, thus the lib not present in superbuild-artifact downloaded in "build" jobs, thus not copied to create packages
  • As fftw tests are now disabled by default, the two tests using it are enabled in fast-build. This build does not relies on a superbuild-artifact, it use only lib installed with system.

changed the description

marked the checklist item FFTW compilation is disabled by default as completed

marked the checklist item One CI job should at least test FFTW tests as completed

marked the checklist item FFTW test are disabled by default as completed

marked the checklist item FFTW is not packaged in "All-in-one" package and in "Dependencies" package: no more fftw in lib, lib/cmake, include and bin as completed

closed with commit 1d72efe3

changed milestone to %9.1.1

added incident legal labels

mentioned in commit 1d72efe3