Skip to content
Snippets Groups Projects

Resolve "Warn otbcli user about unused parameters"

Merged Julien Michel requested to merge 1621-warn-unused-parameters into develop
All threads resolved!

Summary

Solves #1621 (closed).

Rationale

In command-line launcher, check user parameters to detect parameters that will be ignored because their corresponding choice is not selected:

otbcli_ExtractROI  -mode.radius.cx 2 -in ~/tmp/tmp.tif -out ~/tmp/tmp2.tif uint16
WARNING: Parameter -mode.radius.cx will be ignored because -mode is standard. Consider adding -mode radius to application parameters.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


***Check before merging:*** - All discussions are resolved - At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote. - The feature branch is (reasonably) up-to-date with the base branch - Dashboard is green - Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Merge request reports

Merged by Julien MichelJulien Michel 6 years ago (Jun 21, 2018 9:54am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Laurențiu Nicola
  • Laurențiu Nicola
  • Laurențiu Nicola
  • Julien Michel resolved all discussions

    resolved all discussions

  • Julien Michel added 1 commit

    added 1 commit

    • 0a4a7467 - STY: adress reviews and add comments

    Compare with previous version

  • Author Reporter

    One thing: should I use logging interface instead of plain std::cerr ? std::cerr is used for other warnings and errors in this class.

  • Julien Michel resolved all discussions

    resolved all discussions

  • I suppose we can clean up the logging some other time.

  • Victor Poughon
  • Victor Poughon
  • Julien Michel added 1 commit

    added 1 commit

    • d8bf6cae - ENH: Adressing comments from @poughov, with a bit of C++11 seasoning

    Compare with previous version

  • Julien Michel added 1 commit

    added 1 commit

    Compare with previous version

  • Julien Michel resolved all discussions

    resolved all discussions

  • Author Reporter

    Dashboard is green, merging.

  • merged

  • Julien Michel mentioned in commit f13a79c1

    mentioned in commit f13a79c1

  • Cédric Traizet changed milestone to %7.0.0

    changed milestone to %7.0.0

  • Please register or sign in to reply
    Loading