BUG: Be compliant with new cmake policy CMP0072 with cmake > 3.11

fix bug #1653 (closed) fix a typo in a comment in a cmakelists.txt

The issue pop up of pc-christophe with a recent version of cmake:

https://dash.orfeo-toolbox.org/viewConfigure.php?buildid=325190

Our cmake policy management in OTB cmake deserves some love as we maintain for historical reason OLD behaviour for cmake policies (46 and 54).

It should be ported to the NEW behavior and not rely on setting a policy to OLD.

changed the description

added bug packaging labels

Is this better (for compatibility maybe?) than cmake_policy(SET CMP0072 NEW)?

don't know... you're probably right it is perhaps better to revert and just set the policy to NEW in the cmakelistts.

Does an other cmake guru here have an opinion about that?

added 1 commit

• 18c22265 - WRG: set cmake policy 72 in Cmakelists as suggested by Laurentiu

Compare with previous version

I've done what you suggested @lnicola (set cmake policy to NEW in the CMakeLists). let's check the dashboard and merge this if it is ok. Thanks for the review.

added 28 commits

• 18c22265...1d81617e - 27 commits from branch develop
• 98fce8df - Merge branch 'develop' into opengl_glvnd_preferences

Compare with previous version

does not build on pc-christophe :(

That's unfortunate :-(.

Note: I know @mgrizonnet is on holidays so I removed this branch from dashboard testing to avoid dashboard overload. anyone feel free to add it back if you are working on it again.

added 171 commits

• 98fce8df...6243b88b - 170 commits from branch develop
• 866f099b - Merge branch 'develop' into opengl_glvnd_preferences

Compare with previous version

added 4 commits

• 866f099b...8f948ac6 - 2 commits from branch develop
• 447e1151 - Merge remote-tracking branch 'origin/develop' into opengl_glvnd_preferences
• dcc1cb66 - BUG: OpenGL missing libraries dectection should test also GLVND library

Compare with previous version

The branch is green (I've fixed the compilation issue on pc-christophe which was a false alarm). I've got enough vote, merge.

Note that I should submit a other MR to fix the 2 remaining cmake policies warnings.

merged

mentioned in commit 46f657df

mentioned in issue #1722 (closed)

mentioned in commit 382e0fbf