Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 207
    • Issues 207
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !158

ENH: Add box kernel to morphological operations apps

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Laurențiu Nicola requested to merge app-binary-morhological-oper into develop Jul 03, 2018
  • Overview 13
  • Commits 3
  • Pipelines 0
  • Changes 3

Summary

  • remove some code duplication in appBinaryMorphologicalOperations and appGrayScaleMorphologicalOperation
  • add support for box structuring elements to the above
  • rename structype.foo.{x,y}radius parameters to {x,y}radius

Rationale

Box kernels are very common, and they're easy to add they are already available in ITK.

Implementation Details

The refactoring was necessary to avoid having N_kernels * N_filters cases (now it's N_kernels + N_filters instead).

The radii are used by all supported kernels, so they're now unrelated parameters; this avoids some more code duplication.

Additional notes

If we ever want to support image kernels, the radii parameters will make no sense. A warning can be added in that case.

Copyright

The copyright owner is CS ROMANIA and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved

  • At least 2 👍 votes from core developers, no 👎 vote.

  • The feature branch is (reasonably) up-to-date with the base branch

  • Dashboard is green

  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Edited Jul 04, 2018 by Laurențiu Nicola
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: app-binary-morhological-oper