ENH: Add box kernel to morphological operations apps

Summary

• remove some code duplication in appBinaryMorphologicalOperations and appGrayScaleMorphologicalOperation
• add support for box structuring elements to the above
• rename structype.foo.{x,y}radius parameters to {x,y}radius

Rationale

Box kernels are very common, and they're easy to add they are already available in ITK.

Implementation Details

The refactoring was necessary to avoid having N_kernels * N_filters cases (now it's N_kernels + N_filters instead).

The radii are used by all supported kernels, so they're now unrelated parameters; this avoids some more code duplication.

Additional notes

If we ever want to support image kernels, the radii parameters will make no sense. A warning can be added in that case.

Copyright

The copyright owner is CS ROMANIA and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved

• At least 2 votes from core developers, no vote.

• The feature branch is (reasonably) up-to-date with the base branch

• Dashboard is green

• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

changed title from Add box kernels to appBinaryMorphologicalOperations to Add box kernel to appBinaryMorphologicalOperations

changed title from Add box kernel to appBinaryMorphologicalOperations to ENH: Add box kernel to appBinaryMorphologicalOperations

changed the description

changed the description

changed milestone to %7.0.0

added app label

Always a good idea to avoid code duplication. OK to rename parameters and change the app interface. If we want to do now a 7.0 version it is the right moment to do this.

About the parameter rename, we might need to change them back if we ever support image kernels, so I don't insist on it.

Also, it looks like GrayScaleMorphologicalOperation could use the same changes.

added 14 commits

• 7eddde5c...258d3f59 - 11 commits from branch develop
• 9e6e9fd6 - ENH: avoid code duplication in appBinaryMorphologicalOperation
• f0b4d643 - ENH: add box kernel to appBinaryMorphologicalOperation
• 72847acf - ENH: add box kernel to appGrayScaleMorphologicalOperation

Compare with previous version

changed title from ENH: Add box kernel to appBinaryMorphologicalOperations to ENH: Add box kernel to morphological operations apps

Rebased and did the same changes for GrayScaleMorphologicalOperation.

Please use the merge request template

changed the description

@poughov done.

added 1 commit

• b53e0058 - ENH: add box kernel to appGrayScaleMorphologicalOperation

Compare with previous version

Dashboard errors seem to be unrelated (missing QWT?).

There's also a test currently failing on some platforms on develop (apTvFEBinaryMorphologicalOperation) about this application. I think it's unrelated to your MR but let's try to fix before merging this to avoid mixing problems.

@poughov The issue is that there are two different files, QB_Toulouse_Ortho_PAN_Mask.tif and QB_Toulouse_Ortho_PAN_mask.tif.

Windows and Mac OS have case-insensitive file systems, so the test probably picks up the wrong file on those platforms. We should probably remove the latter, since it's not used.

otb-data@1bbed80e

mentioned in merge request otb-data!1 (merged)