Resolve "QLayout: Attempting to add QLayout "" to otb::Wrapper::QtWidgetParameterGroup "", which already has a layout"

Review changes
Download
Patches
Plain diff

Merged Resolve "QLayout: Attempting to add QLayout "" to otb::Wrapper::QtWidgetParameterGroup "", which already has a layout"

1645-qlayout into develop

Overview 1
Commits 1
Pipelines 0
Changes 25

Merged Victor Poughon requested to merge 1645-qlayout into develop 6 years ago

Overview 1
Commits 1
Pipelines 0
Changes 25

Summary

Create QLayout without a parent in the constructor, as is done in QT documentation.

Rationale

Closes #1645 (closed)

Implementation Details

The QLayout constructor sets the parent's widget layout to this. In MR !125 (merged) I added this as default parent to all QObjects (including QLayouts) to avoid potential memory leaks. This is bad idea for layouts because a widget's layout cannot be changed without removing the existing one first. This causes the warning reported in #1645 (closed) for QtWidgetView and QtWidgetParameterGroup because they create a layout not intended for this. When adding a layout to this later, the warning is emitted.