Enhance SARDeburst

Summary

New Mode for SARDeburst application and two new applications into OTB : SARBurstExtraction and SARConcatenateBursts.

Rationale

This new mode and applications will be used by some processing chains such as DiapOTB chain for IW S1 products.

Implementation Details

Classes and files

Three classes was changed :

• ossimSarSensorModel : New functions and spread deburst function to include a new mode (onlyvalidsamples : keep into debursted image only valid samples).
• otbSarSensorModelAdapter : New interfaces for ossimSarSensorModel functions.
• otbSarDeburstImageFilter : New mode onlyvalidsamples.

Two filters have been added :

• otbSarBurstExtractionImageFilter
• otbSarConcatenateBurstsImageFilter

Applications

One application has been changed and two have been added:

• otbSARDeburst : New mode to keep only valid samples into output image.
• otbSARBurstExtraction : New application to extract all bursts or one selected burst from an IW S1 image.
• otbSARConcatenateBursts : New application to concatenate and deburst a list of bursts (IW S1 products).

Additional notes

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Thank you for the MR, it looks great! (After code review of course :)). Since you've done a bit of work on adding various SAR processing applications, it would be great if we had more documentation. Maybe a "deburst" section in the cookbook or a blog post? Let us know if you are interested in working on any of that.

added 1 commit

• 205c0a87 - WRG : Code review

Compare with previous version

added 1 commit

• 7008ed1e - WRG : Code review (part 2)

Compare with previous version

resolved all discussions

added 1 commit

• ec3c4df3 - WRG : Code review (part 3)

Compare with previous version

@ussegliog would you be able to write tests for the new filters you added ?

I registered the branch for dashboard testing.

I can write source files to test new applications (BurstExtraction and SARConcatenateBursts) with the file otbSarDeburstFilterTest.cxx as template.

However, I don't know input data used into OTB tests and I don't have references to compare with.

resolved all discussions

added 1 commit

• be2726cd - BUG : Fix tests

Compare with previous version

resolved all discussions

added 1 commit

• e98b1e4a - COMP : initialization of arrays

Compare with previous version

resolved all discussions

added 1 commit

• 69f495c7 - BUG : Correction into keyword list for number of samples and of lines

Compare with previous version

resolved all discussions

added 1 commit

• 432ade5d - DOC : Update Doxygen for SARConcatenateBursts application

Compare with previous version

resolved all discussions

added 1 commit

• 25867d2b - ENH : Tests for SARDeburst, SARBurstExtraction and SARConcatenateBursts applications

Compare with previous version

resolved all discussions

added 1 commit

• 19726a53 - ENH : New mode for SARBurstExtraction application

Compare with previous version

resolved all discussions

added 1 commit

• 21a630c6 - BUG : Fix tests

Compare with previous version

resolved all discussions

added 1 commit

• 938ba6a5 - COMP : Fix std::min

Compare with previous version

Dashboard looks ok, merging.

merged

mentioned in commit 83c6e649

Thank you.

Cookbook build is broken with this merge. I am looking into it

mentioned in merge request !346 (merged)

fixed in !346 (merged)

added feature label