Refactor PanSharpening module to use FunctorImageFilter everywhere

Summary

This MR refactors PanSharpening module to use FunctorImageFilter.

Rationale

Avoids relying on TernaryFunctorImageFilter (either itk version or our own version). Gain performances by using the void operator()(Tout& out, ...) form.

Implementation Details

Appart from the removal of otb::ImageFusionBase which was a base class used only by BayesianFusionImageFilter, all modifications are internal to filters and do not change the API.

A small refactoring has been done PanSharpening application to avoid a compilation error (trying to convert the BayesianFusionImageFilter to the wrong instance of ImageToImageFilter). Maybe we could use the new RegisterPipeline() method here.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 👍 votes from core developers, no 👎 vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

Modules/Applications/AppFusion/app/otbPansharpening.cxx

@@ -53,8 +53,6 @@ public:
   typedef itk::SmartPointer<Self>       Pointer;
   typedef itk::SmartPointer<const Self> ConstPointer;
 
-  typedef itk::ImageToImageFilter<FloatVectorImageType, FloatVectorImageType> FusionFilterType;
-
   typedef otb::SimpleRcsPanSharpeningFusionImageFilter<FloatImageType, FloatVectorImageType, FloatVectorImageType> SimpleRCSFilterType;
 
   typedef otb::LmvmPanSharpeningFusionImageFilter
@@ -176,7 +174,9 @@ private:
 
       filter->UpdateOutputInformation();
       otbAppLogINFO( << "Simple RCS algorithm" );
-      m_FusionFilter = filter;
+      m_Ref.push_back(filter.GetPointer());
+      SetParameterOutputImage("out", filter->GetOutput());
+
       break;
       }
       case 1:
@@ -203,8 +203,9 @@ private:
       filter->UpdateOutputInformation();
 
       otbAppLogINFO( << "Lmvm algorithm" );
+      m_Ref.push_back(filter.GetPointer());
+      SetParameterOutputImage("out", filter->GetOutput());
 
-      m_FusionFilter = filter;
       break;
       }
       case 2:
@@ -224,7 +225,9 @@ private:
 
       filter->UpdateOutputInformation();
       otbAppLogINFO( << "Bayesian fusion algorithm" );
-      m_FusionFilter = filter;
+
+      m_Ref.push_back(filter.GetPointer());
+      SetParameterOutputImage("out", filter->GetOutput());
 
       break;
       }
@@ -236,12 +239,9 @@ private:
       }
       return;
       }
-
-    SetParameterOutputImage("out", m_FusionFilter->GetOutput());
   }
 
   std::vector<itk::ProcessObject::Pointer> m_Ref;
-  FusionFilterType::Pointer m_FusionFilter;
 };
 }
 }