Remove Version installation in build_dir

Summary

Fix #1790 (closed) by removing installation of VERSION in build_dir.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement

@sebastic can you confirm that the patch is OK?

added 1 deleted label

It is currently identical to the patch included in the Debian package, so should be OK.

The directory is still installed as well, that may need to be removed.

While I chose to install the VERSION file in /usr/share/doc/otb as it was in 6.6.0, for the QGIS integration it may need to be installed in /usr/share/otb (using ${OTB_INSTALL_DATA_DIR}) instead. I don't use OTB nor its QGIS integration, so I cannot confirm that. @rkanavath might.

The directory needs to be install for QGIS actually.

currently qgis otb provider is using share/doc/otb for VERSION file[1]. But this can be changed to share/otb if thats inline with debian packages. version number/file has no important role in provider other than reporting to users. A Change to qgis provider code is easy now as the PR is not done yet to upstream. So I am okay with this one line change.

[1] https://gitlab.orfeo-toolbox.org/orfeotoolbox/qgis-otb-plugin/blob/master/otb/OTBAlgorithmProvider.py#L243

@sebastic do you think it would be better to put VERSION and LICENSE files in /usr/share/otb/ or just the VERSION file?

@aregimbeau status?

@aregimbeau I do not know if it is relevant but to my opinion LICENSE and VERSION should be installed in the same place. We should close this issue somehow.

@jmichel I honestly have no opinion whatsoever on that, this MR is here to solve #1790 (closed) (and to avoid installing file in build directory which is a good thing!).

Ok so lets do this : install both LICENCE and VERSION in the same place. And merge.

@aregimbeau can you take care of it ?

mentioned in commit 74115d42

merged