COMP: allow Qt5 to compile on old kernels
Small compilation fix for QT5 on SuperBuild. It refers to an issue I first had on #1687 (closed). It appeared again when working on CI. The new option USE_LOW_KERNEL_VERSION
can be used to disable some features that require a more recent kernel version on Linux. This will also create more portable binaries.
Typical use case: compile SuperBuild in a Ubuntu 18.04 docker running on Ubuntu 14.04 host.
Merge request reports
Activity
added bug label
added patch label
The tests failing on the dashboard are not linked with QT5.
Edited by Antoine Regimbeauadded 21 commits
-
38c1f53f...ffcfca59 - 19 commits from branch
develop
- 83519b4f - PKG: avoid dependency to libjson-c on Unix
- 186d3f92 - MRG: Synchronize with branch develop
-
38c1f53f...ffcfca59 - 19 commits from branch
hmmm, could also be a source of problems. We will have libjson symbols inside libgdal and they can conflict with other libs using libjson.
@rkanavath: what do you think?
regarding low kernel version:
if it fixes your issue with qt, you can disable getentrory and renameat2. I remember previously having issue with getentropy on newer version of osx. I would suggest to make it default rather than controlling with a cmake variable. superbuild of qt in otb is custom for OTB. We don't care if that qt build won't work with other tools.
regarding libjson-c: which library is using libjson other than gdal and ossim?
Ok, apparently
--with-libjson-c=no
is not supported, I'll have to useinternal
.@rkanavath: I can set the option
USE_LOW_KERNEL_VERSION
to ON by default. Remember that SuperBuild is not only for packagers as ourselves. Should I also disable getentropy for macOS ?added 1 commit
- a441f67e - SuperBuild: use internal libjson-c from GDAL
@gpasero , yes you can disable it for osx. btw, I was refering to otb binaries (otbgui, mapla, monterverdi) and not just packages.
added 1 commit
- 336b3534 - SuperBuild: USE_LOW_KERNEL_VERSION=ON by default, also used on macOS
mentioned in commit 8a7a9329
changed milestone to %7.0.0