Qgis parameter
Summary
A new PR to QGIS has been made and accepted (https://github.com/qgis/QGIS/pull/9542).
This MR aims at solving the issue on OTB side
Copyright
The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.
Check before merging:
- All discussions are resolved
- At least 2
votes from core developers, no vote. - The feature branch is (reasonably) up-to-date with the base branch
- Dashboard is green
- Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Merge request reports
Activity
changed milestone to %7.0.0
added 1 commit
- 636ee104 - Try to find the correct folder for artifacts
I added a test (locally) that expose issues reported on qgis-otb-plugin#30 (closed) and https://issues.qgis.org/issues/21373 https://issues.qgis.org/issues/21374
I have a fix (on test) for plugin code that will allow us to work with QGIS 3.2+ and otb 6.6+
I will update in detail about that in qgis-otb-plugin#30 (closed)
@aregimbeau , Thanks for artifact. I kind of like that word in development (Warehouse13
artifacts aren't working. qgis show this error:
src/core/qgsmessagelog.cpp:29 : (logMessage) [1372ms] 2019-03-14T15:57:53 Processing[0] Loading OTB '6.7.0'. src/core/qgsmessagelog.cpp:29 : (logMessage) [34ms] 2019-03-14T15:57:53 Processing[2] Could not open OTB algorithm from file: /home/rashad/projects/qgis/otb/build/share/otb/description/ComputePolylineFeatureFromImage.txt line=QgsProcessingParameterVectorDestination|out|Output Vector Data|None|False Error: Traceback (most recent call last): File "/home/rashad/projects/qgis/build/output/python/plugins/processing/core/parameters.py", line 235, in getParameterFromString params[2] = int(params[2]) TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/rashad/projects/qgis/build/output/python/plugins/processing/algs/otb/OtbAlgorithm.py", line 137, in defineCharacteristicsFromFile param = getParameterFromString(line, 'OtbAlgorithm') File "/home/rashad/projects/qgis/build/output/python/plugins/processing/core/parameters.py", line 237, in getParameterFromString params[2] = getattr(QgsProcessing, params[2].split(".")[1]) AttributeError: 'NoneType' object has no attribute 'split' src/core/qgsmessagelog.cpp:29 : (logMessage) [6ms] 2019-03-14T15:57:53 Processing[2] Could not open OTB algorithm from file: /home/rashad/projects/qgis/otb/build/share/otb/description/ComputePolylineFeatureFromImage.txt Error: Traceback (most recent call last): File "/home/rashad/projects/qgis/build/output/python/plugins/processing/core/parameters.py", line 235, in getParameterFromString params[2] = int(params[2]) TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/rashad/projects/qgis/build/output/python/plugins/processing/algs/otb/OtbAlgorithmProvider.py", line 115, in createAlgsList algs.append(OtbAlgorithm(group, name, descriptionFile)) File "/home/rashad/projects/qgis/build/output/python/plugins/processing/algs/otb/OtbAlgorithm.py", line 74, in __init__ self.defineCharacteristicsFromFile() File "/home/rashad/projects/qgis/build/output/python/plugins/processing/algs/otb/OtbAlgorithm.py", line 178, in defineCharacteristicsFromFile raise e File "/home/rashad/projects/qgis/build/output/python/plugins/processing/algs/otb/OtbAlgorithm.py", line 137, in defineCharacteristicsFromFile param = getParameterFromString(line, 'OtbAlgorithm') File "/home/rashad/projects/qgis/build/output/python/plugins/processing/core/parameters.py", line 237, in getParameterFromString params[2] = getattr(QgsProcessing, params[2].split(".")[1]) AttributeError: 'NoneType' object has no attribute 'split'
Here is the diff of descriptor file(errored):
$ diff -buN description.new/ComputePolylineFeatureFromImage.txt description/ComputePolylineFeatureFromImage.txt --- description.new/ComputePolylineFeatureFromImage.txt Thu Mar 14 16:01:46 2019 +++ description/ComputePolylineFeatureFromImage.txt Thu Mar 14 15:58:46 2019 @@ -8,4 +8,4 @@ QgsProcessingParameterNumber|elev.default|Default elevation|QgsProcessingParameterNumber.Double|0|True QgsProcessingParameterString|expr|Feature expression|None|False|False QgsProcessingParameterString|field|Feature name|None|False|False -QgsProcessingParameterVectorDestination|out|Output Vector Data +QgsProcessingParameterVectorDestination|out|Output Vector Data|None|False
There are many other apps failing too.. Basically all of QgsProcessingParameterVectorDestination is malformed.
HTH
added 1 commit
- 9a9231c0 - REFAC: refactor and add option for vector data
added 284 commits
-
77a89e51...edd0febe - 283 commits from branch
develop
- 9a33b13c - Merge branch 'develop' into qgis_parameter_status_2
-
77a89e51...edd0febe - 283 commits from branch
added 173 commits
-
ec614bca...ebab3404 - 172 commits from branch
develop
- a70e213b - Merge branch 'develop' into qgis_parameter_status_2
-
ec614bca...ebab3404 - 172 commits from branch
added 768 commits
-
a70e213b...90edfc9f - 767 commits from branch
develop
- 0bed454a - Merge branch 'develop' into qgis_parameter_status_2
-
a70e213b...90edfc9f - 767 commits from branch
added 1 commit
- 1afe1bc1 - [BUG] set fileFilter to None for ParameterType_OutputFilename
@aregimbeau , I had pushed a fix for output parameter file types.
tested TrainImagesClassifier, Smoothing and ExtractROI and it seems all are working.
I found a bug in in otb processing provider code which is not part of this MR. (needs to push to qgis and then release a new version of it)
You can merge this changes into develop and update OTB package used in qgis travis ci
added 312 commits
-
1afe1bc1...2e4c87da - 311 commits from branch
develop
- 453a86c2 - Merge branch 'develop' into qgis_parameter_status_2
-
1afe1bc1...2e4c87da - 311 commits from branch
added 42 commits
-
453a86c2...1dfd7482 - 41 commits from branch
develop
- b0fc47ef - Merge branch 'develop' into qgis_parameter_status_2
-
453a86c2...1dfd7482 - 41 commits from branch
added 5 commits
-
b0fc47ef...d681f9f6 - 4 commits from branch
develop
- 51759cbb - Merge branch 'develop' into qgis_parameter_status_2
-
b0fc47ef...d681f9f6 - 4 commits from branch
mentioned in commit 80bfa6ee
removed Doing label
added feature label