Skip to content
Snippets Groups Projects

Fix OTBApplicationOutputImageChanged and ExecutionDone slots not being called

Merged Victor Poughon requested to merge bug-qt-execute into develop

Summary

Fix a bug where output images are not loaded after app execution in monteverdi.

It was introduced by the combination of !161 (merged) and !441 (merged), it was caused by two problems:

  • Overriding a non virtual slot in mvdQtWidgetView.h
  • Broken signal/slot connection using the old Qt syntax in mvdMainWindow.cxx

Fixed by making the overriden function virtual, and using the new Qt 5 syntax for signal/slot connection.

Rationale

Fix the bug.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Edited by Victor Poughon

Merge request reports

Merge request pipeline #655 passed

Merge request pipeline passed for 82a28fb4

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading