Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 206
    • Issues 206
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !454

Filter mouse wheel event in QComboBox of app parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Victor Poughon requested to merge filter-wheel-combobox into develop Apr 02, 2019
  • Overview 1
  • Commits 3
  • Pipelines 6
  • Changes 9

Summary

In otbgui, block mouse wheel events of QComboBox widgets for choice parameters, and output image pixel type selection. This is to improve UX when scrolling in applications with many parameters. Scrolling in the list of parameters can result in a combo box taking the focus, and users accidentally changing a choice parameter or a numerical value.

Note that it's already in place for int and float parameters. This MR refactors the event filter in QtWidgetParameterBase so that any children can register it.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: filter-wheel-combobox