Fix name of USE_SYSTEM_QT5 cmake var

This variable should be called USE_SYSTEM_QT5 not USE_SYSTEM_QT. Currently it is not possible to use the system's QT5 with USE_SYSTEM_QT=ON, it should be USE_SYSTEM_QT5=ON.

added patch label

I remember discussion where we agreed on a QT variable instead of QT5 which is harder to maintain for upgrade in version... A change in the macro argument ADDTO_DEPENDENCIES_IF_NOT_SYSTEM can do the job without changing the name of the variable (use QT instead of QT5).
EDIT Actually this need to be done in other macro. But I keep my position on keeping this variable name as QT and not QT5.

I agree and I don't mind either way, but right now there is a bug: if I set -DUSE_SYSTEM_QT=ON SuperBuild does not take the system Qt and does not emit a warning because the cmake option with that name exists but has no effect. I guess we should also rename the file External_qt5.cmake for consistency.

Yep, so we fix it with your patch and open an issue on that? If so, +1!

ok for me!

mentioned in issue #1875 (closed)

merged

mentioned in commit fe002c63

changed milestone to %7.0.0

added bug label