Skip to content
GitLab

Fix Superbuild default OTB_DATA_ROOT

Merged Cédric Traizet requested to merge superbuild_default_dataroot into develop

Summary

Change the default OTB_DATA_ROOT to ${OTB-SuperBuild_SOURCE_DIR}/../Data in Superbuild.

Rationale

There is a OTB_DATA_ROOT cmake variable in the SuperBuild project. Currently, this variable is initialized with :

find_path(OTB_DATA_ROOT README-OTB-Data
  PATHS
  $ENV{OTB_DATA_ROOT}
  ${OTB-SuperBuild_SOURCE_DIR}/../../OTB-Data)

But the default location for the data folder in OTB is now OTB_SRC/Data (since the migration to git lfs), so we should modify the default accordingly, as it is done in the OTB project.

This MR also removes the $ENV{OTB_DATA_ROOT} from PATHS/HINTS option of find_path in otb and Superbuild. The right way to set a custom data root is to add a cmake option -DOTB_DATA_ROOT when calling cmake.

Additional notes

This MR will be tested as superbuild branch on the dashboard. It is probably the cause of most of the failing tests on windows platforms.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit