Do not return empty requested region in case StreamingWarpImageFilter

Summary

Do not return empty requested region in case StreamingWarpImageFilter legitimately asks for a requested region outside of input largest possible region, since it can mess with upstream filters that will throw InvalidRequestedRegionException because ImageRegion::Crop() can not crop empty regions and thus returns false.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Modules/Core/Transform/include/otbStreamingWarpImageFilter.hxx

@@ -230,24 +230,9 @@ StreamingWarpImageFilter<TInputImage, TOutputImage, TDisplacementField>
     {
     inputPtr->SetRequestedRegion(inputRequestedRegion);
     }
-  else
-    {
-
-    inputFinalSize.Fill(0);
-    inputRequestedRegion.SetSize(inputFinalSize);
-    inputFinalIndex.Fill(0);
-    inputRequestedRegion.SetIndex(inputFinalIndex);
-
-    // store what we tried to request (prior to trying to crop)
-    inputPtr->SetRequestedRegion(inputRequestedRegion);
-
-//    // build an exception
-//    itk::InvalidRequestedRegionError e(__FILE__, __LINE__);
-//    e.SetLocation(ITK_LOCATION);
-//    e.SetDescription("Requested region is (at least partially) outside the largest possible region.");
-//    e.SetDataObject(inputPtr);
-//    throw e;
-    }
+  // Here we do not throw an exception, we just do nothing since
+  // resampling filter can legitimately ask for a region outside of
+  // input's largest possible region.
  }