Contributors check
The shell script and the modification of the CI script provided by this merge request aim to identify the unknown authors (i.e. authors of commits not listed in an external reference file) to invite the team to check if these authors have already signed the contributor license agreement (CLA). When this is done, the authors must be added to the reference list.
Merge request reports
Activity
Paradoxically, the fail of the
contributors-check
job demonstrates that the script works fine! Indeed, some modifications have been made by a new contributor (Achille Talon) whose name does not appear in the reference list. Therefore, the team must be warned (the job fails on purpose) in order to verify if this "contributor" is a new identity used by an already known contributor or a real new contributor who must sign the contributor license agreements.To conclude, from my point of view, my merge request can be accepted. :)
Another possible strategy is to first accept my other merge request (!577 (merged)) that provides an updated
.mailmap
file. I will then be able to take into account this change into this merge request and the job will be successful.I would be in favor of merging !577 (merged) first, it would demonstrates that the mailmap works correctly.
Dashboard is green for !577 (merged), can we merge it now ?
!577 (merged) has been merged, you can retry/sync your branch.
added 41 commits
-
e2824101...f8367d9d - 40 commits from branch
orfeotoolbox:develop
- c6cead69 - Merge branch 'develop' into contributors_check
-
e2824101...f8367d9d - 40 commits from branch
It works! :)
See job https://gitlab.orfeo-toolbox.org/sdinot/otb/-/jobs/10959
mentioned in commit 1d5da785
changed milestone to %7.0.0