Enhance StreamingStatisticsMapFromLabelImageFilter
Summary
Improves the otbStreamingStatisticsMapFromLabelImageFilter with the following enhancements:
- Compute count, mean, standard deviation, min, max
- Multithreaded
Rationale
A class named StatisticsAccumulator handles the update of statistics. I feel that in a near future refactoring we could create such container(s) for statistics. This way, we could reuse this in many otb image statistics components (StreamingImageStatistics and co.). Moreover, we could enrich the persistent filter base classes to enable the (optional) native support of MPI. (But of courses this deserve a complete new RFC)
Implementation Details
Classes and files
Give an overview of the implementation: main changes made to classes, files and modules. Do not paste complete diff, as it is available in the merge request already.
Applications
Describe any changes made to existing applications, or new applications that have been added.
Tests
Describe the testing strategy for new features.
Documentation
List or link documentation modifications that were made (doxygen, example, Software Guide, application documentation, CookBook).
Additional notes
List remaining open issues if any, and additional notes.
Copyright
The copyright owner is IRSTEA and has signed the ORFEO ToolBox Contributor License Agreement
Merge request reports
Activity
added 1 commit
- ef0c1f1e - DOC: correct documentation + code source indent
added 1 commit
- 37dc36c0 - REFAC: rename accumulatorMaps to m_AccumulatorMaps
added patch label
mentioned in merge request !62 (closed)
added 354 commits
-
229f72e6...f13a79c1 - 353 commits from branch
develop - 2c6d95f4 - Merge branch 'develop' into enhance_mapfromlabelstats
-
229f72e6...f13a79c1 - 353 commits from branch
removed patch label
@remicress I've removed the patch label from this merge request as it is for small patch which do not imply to test them on the dashboard.
The dashboard concerning this MR is good apart from warning on Windows (also have a look to hulk platform maybe). I think that they should be fixed:
https://dash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=325179
So after this you just have to update the branch against develop and you'll be ready to merge this one (you've got 2 +1)!
added 6 commits
-
1874afe0...01f22368 - 5 commits from branch
develop - 0905f8a8 - Merge branch 'develop' into enhance_mapfromlabelstats
-
1874afe0...01f22368 - 5 commits from branch
added 5 commits
-
0905f8a8...b3e93bf9 - 4 commits from branch
develop - 68e8ff7a - Merge branch 'develop' into enhance_mapfromlabelstats
-
0905f8a8...b3e93bf9 - 4 commits from branch
-
@remicress .
[[falltrough]]is ignored in C++11 and 14, and taken into account by the compilers from C++17 onward. Except that it seems that VC++ emits a warning telling us that it's not recognized yet :( My mistaken then.Two choices:
- we can remove it
- we can add an option into the CMakeLists.txt files for VC++ case to tell them to silence
C5030warning. Note that it can also be done with pragmas: https://stackoverflow.com/questions/7159348/disable-single-warning-error
Status: we are waiting for @remicress CLA and will be go for merge as soon as we receive it
added 97 commits
-
615ce5ed...93dcabad - 96 commits from branch
develop - 9216fb8e - Merge branch 'develop' into 'enhance_mapfromlabelstats'
-
615ce5ed...93dcabad - 96 commits from branch
-
We have received Rémi's CLA.
I just fixed the conflict with develop. Let's wait tomorrow dashboard and merge if green.
Edited by Victor Poughon mentioned in commit a7d3e7ec
mentioned in issue #1722 (closed)
mentioned in issue #1682 (closed)
