Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 207
    • Issues 207
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !596

Move Mosaic in OTB

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rémi Cresson requested to merge app_mosaic into develop Sep 19, 2019
  • Overview 12
  • Commits 15
  • Pipelines 22
  • Changes 29

Summary

Move Mosaic remote module inside the Orfeo ToolBox.

Rationale

Since a few years Mosaic is quite stable. It's time to integrate it once for all.

Implementation Details

Classes

The Modules/Filtering/Mosaic folder was created to host most of the include stuff of the Mosaic remote module. Only the otbStreamingStatisticsMosaicFilter has been moved in the Modules/Filtering/Statistics module.

Applications

I've added the Mosaic application in AppImageUtils.

Tests

I've put the application tests in AppImageUtils, however there is no test for the Mosaic and Modules/Filtering/Statistics modules. Should I create some? I've no idea what tests could complete the application tests.

Additional notes

Feel free to debate, comment, etc. I recon that I've written nicer c++.

Copyright

The copyright owner is Rémi Cresson (IRSTEA/INRAE) and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: app_mosaic