Move Mosaic in OTB

Summary

Move Mosaic remote module inside the Orfeo ToolBox.

Rationale

Since a few years Mosaic is quite stable. It's time to integrate it once for all.

Implementation Details

Classes

The Modules/Filtering/Mosaic folder was created to host most of the include stuff of the Mosaic remote module. Only the otbStreamingStatisticsMosaicFilter has been moved in the Modules/Filtering/Statistics module.

Applications

I've added the Mosaic application in AppImageUtils.

Tests

I've put the application tests in AppImageUtils, however there is no test for the Mosaic and Modules/Filtering/Statistics modules. Should I create some? I've no idea what tests could complete the application tests.

Additional notes

Feel free to debate, comment, etc. I recon that I've written nicer c++.

Copyright

The copyright owner is Rémi Cresson (IRSTEA/INRAE) and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

changed milestone to %7.0.0

added app feature labels

added 1 commit

• 21838d46 - COMP: include OTBMosaic module in OTBStatistics

Compare with previous version

added 1 commit

• 45a04f30 - ADD: remove mosaic from directory handler

Compare with previous version

TODO:

• rename .txx to .hxx
• apply clang format
• copyrights

You need to remove reference to the Mosaic remote module in Modules/Remote and in SuperBuild/CMake/External_otb.cmake I think.

I already created the branch for release 7.0, but if this is merged quickly, I think this can be included in the release (I'll recreate the branch). @coreteam what do you think ?

It's fine for me

added 2 commits

• e182b95e - REFAC: txx->hxx
• d44d9483 - COMP: remove Mosaic.remote.cmake

Compare with previous version

It could be great. I can fix this today

added 1 commit

• 9a4ac60a - REFAC: ITK_OVERRIDE-->override

Compare with previous version

added 3 commits

• 06e3dfae - DOC: copyright
• 73bf52a1 - DOC: copyright
• f50472ad - REFAC: apply clang-format

Compare with previous version

added 1 commit

• a6593d23 - REFAC: add \ingroup

Compare with previous version

added 1 commit

• 855a5274 - DOC: fix copyright

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 28f4b84d - CI: remove Mosaic from the remote module list enabled in CI builds

Compare with previous version

added a commit to remove Mosaic (the remote module) from CI.

It was causing this warning

resolved all threads

added 1 commit

• aecf9639 - DOC: Fix shell type copyrights for Mosaic

Compare with previous version

resolved all threads

added 1 commit

• c490d43f - CI: add IRSTEA to possible copyrights in shell like headers

Compare with previous version

CI is green !

Welcome to OTB Mosaic :)

merged

mentioned in commit 753dd44b

mentioned in issue #1969 (closed)