{"id":731,"iid":650,"description":"#### Summary Simplify the BinaryMorphologicalOperation. Before: ``` Parameters: MISSING -in Input Image (mandatory) MISSING -out [pixel] Output Image [pixel=uint8/uint16/int16/uint32/int32/float/double/cint16/cint32/cfloat/cdouble] (default value is float) (mandatory) -channel Selected Channel (mandatory, default value is 1) -structype Type of structuring element [box/ball/cross] (mandatory, default value is box) -xradius Structuring element X radius (mandatory, default value is 5) -yradius Structuring element Y radius (mandatory, default value is 5) -filter Morphological Operation [dilate/erode/opening/closing] (mandatory, default value is dilate) -filter.dilate.foreval Foreground value (mandatory, default value is 1) -filter.dilate.backval Background value (mandatory, default value is 0) -filter.erode.foreval Foreground value (mandatory, default value is 1) -filter.erode.backval Background value (mandatory, default value is 0) -filter.opening.foreval Foreground value (mandatory, default value is 1) -filter.opening.backval Background value (mandatory, default value is 0) -filter.closing.foreval Foreground value (mandatory, default value is 1) -ram Available RAM (MB) (optional, off by default, default value is 256) -progress Report progress -help Display long help (empty list), or help for given parameters keys ``` After: ``` Parameters: MISSING -in Input Image (mandatory) MISSING -out [pixel] Output Image [pixel=uint8/uint16/int16/uint32/int32/float/double/cint16/cint32/cfloat/cdouble] (default value is float) (mandatory) -channel Selected Channel (mandatory, default value is 1) -structype Type of structuring element [box/ball/cross] (mandatory, default value is box) -xradius Structuring element X radius (mandatory, default value is 5) -yradius Structuring element Y radius (mandatory, default value is 5) -foreval Foreground value (mandatory, default value is 1) -backval Background value (mandatory, default value is 0) -filter Morphological Operation [dilate/erode/opening/closing] (mandatory, default value is dilate) -ram Available RAM (MB) (optional, off by default, default value is 256) -progress Report progress -help Display long help (empty list), or help for given parameters keys ``` #### Rationale Simpler is better! #### Implementation Details ##### Classes and files * Documentation/Cookbook/rst/recipes/featextract.rst * Modules/Applications/AppMorphology/app/otbBinaryMorphologicalOperation.cxx * Modules/Applications/AppMorphology/test/CMakeLists.txt ##### Applications * Modules/Applications/AppMorphology/app/otbBinaryMorphologicalOperation.cxx: remove the following parameters; `filter.erode.foreval`, `filter.erode.backval`, `filter.dilate.foreval`, `filter.dilate.backval`, `filter.opening.foreval`, `filter.opening.backval`, `filter.closing.foreval` with `foreval` and `backval` ##### Tests * Modules/Applications/AppMorphology/test/CMakeLists.txt: update application parameters in test ##### Documentation * `Documentation/Cookbook/rst/recipes/featextract.rst`: update the doc wrt the changes (btw I've updated some old stuff regarding the new `xradius` and `yradius`) #### Copyright The copyright owner is *Rémi Cresson (IRSTEA)* and has signed the ORFEO ToolBox Contributor License Agreement.

***Check before merging:*** - All discussions are resolved - At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote. - The feature branch is (reasonably) up-to-date with the base branch - Dashboard is green - Copyright owner has signed the ORFEO ToolBox Contributor License Agreement - Optionally, run `git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i` on latest changes and commit","title":"Simplify binary morpho app","merge_params":{"force_remove_source_branch":"1"},"state":"merged","source_branch":"simplify_binary_morpho_app","target_branch":"develop","source_branch_path":"/orfeotoolbox/otb/-/tree/simplify_binary_morpho_app","target_branch_path":"/orfeotoolbox/otb/-/tree/develop","diff_head_sha":"5a23e42437972c9da0052aca253aaac44f2c838a","create_note_path":"/orfeotoolbox/otb/notes?target_id=731&target_type=merge_request","preview_note_path":"/orfeotoolbox/otb/-/preview_markdown?target_id=650&target_type=MergeRequest","can_receive_suggestion":true,"create_issue_to_resolve_discussions_path":null,"new_blob_path":null,"current_user":{"can_create_note":false,"can_update":false,"can_create_confidential_note":false},"is_project_archived":false,"project_id":53}

Simplify binary morpho app

Summary

Rationale

Implementation Details

Classes and files

Applications

Tests

Documentation

Copyright

Merge request reports