COMP: Remove RemoteSensingRegion assignment operator

Summary

The default copy and move constructors and assignment operators are fine, there's no need to implement them manually.

Rationale

Spotted on Debian Testing with GCC 9.2.1:

In file included from /otb/Modules/Core/VectorDataBase/include/otbPolyLineParametricPathWithValue.h:34,
                 from /otb/Modules/Core/VectorDataBase/include/otbPolygon.h:24,
                 from /otb/Modules/Core/LabelMap/include/otbAttributesMapLabelObject.h:33,
                 from /otb/Modules/Core/LabelMap/test/otbLabelObjectMapVectorizer.cxx:24:
/otb/Modules/Core/ImageBase/include/otbRemoteSensingRegion.h:118:8: note: because 'otb::RemoteSensingRegion<double>' has user-provided 'void otb::RemoteSensingRegion<TType>::operator=(const Self&) [with TType = double; otb::RemoteSensingRegion<TType>::Self = otb::RemoteSensingRegion<double>]'
  118 |   void operator=(const Self& region)
      |        ^~~~~~~~

Copyright

The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

added bug label

changed title from COMP: Fix implement copy ctor for RemoteSensingRegion to COMP: Implement copy ctor for RemoteSensingRegion

changed the description

added 1 commit

• 14ab942f - COMP: Implement copy ctor for RemoteSensingRegion

Compare with previous version

Can I see the errors from fast-build?

 Build project
   Each symbol represents 1024 bytes of output.
   '!' represents an error and '*' a warning.
    ..................................................  Size: 49K
    ................**.**.!*.**..!*..!!*..!!*..** Size of output: 94K
   16 Compiler errors
   17 Compiler warnings

https://cdash.orfeo-toolbox.org/buildSummary.php?buildid=30209

added 1 commit

• 25c44cf7 - COMP: Implement copy ctor for RemoteSensingRegion

Compare with previous version

resolved all threads

added 1 commit

• 629cdfd2 - COMP: Remove RemoteSensingRegion assignment op

Compare with previous version

changed title from COMP: Implement copy ctor for RemoteSensingRegion to COMP: Remove RemoteSensingRegion assignment operator

changed the description

mentioned in merge request !682 (closed)

changed milestone to %7.1.0

Do we have a build with GCC 9.2.1 on the CI ? And I don't understand why it fails on our Debian build..

It fails because it's not rebased over the MR that removed the GDALDestroy call.

it fails on debian because this branch does not include !677 (merged)

I don't think we use gcc 9 on CI, as most builds are using clang

On debian the CI uses gcc 8, but we could use gcc 9.

I used the compiler in the official Debian Testing Docker image. I haven't yet tried the OTB images.

I remember why we are using gcc 8 and not 9 (well git helped ^^). In ITK there is list of supported compiler defined in this header, and gcc 9 is not supported in ITK v4.13.2. It is possible to patch the file (and it is fixed in the branch release-4.13 of ITK), but in CI we have to use gcc 8.