Skip to content
Snippets Groups Projects

ENH: allow HTTP GDAL datasets

Merged Laurențiu Nicola requested to merge allow-gdal-http into develop

Summary

Allow IOGDAL to open HTTP and HTTPS datasets.

Rationale

These were disabled in 6b1a6270 as a work-around for a pre-GDAL 1.11 bug. We no longer support GDAL 1, let's remove this check and see what happens.

Copyright

The copyright owner is Laurențiu Nicola (CS ROMANIA) and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Laurențiu Nicola

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added feature label

  • Laurențiu Nicola changed the description

    changed the description

  • Cédric Traizet changed milestone to %7.1.0

    changed milestone to %7.1.0

  • I tested it locally and it works :

    bin/otbcli_EdgeExtraction -in "/vsicurl/https://www.orfeo-toolbox.org/CookBook/_images/cuprite_rgb.png"  -out /tmp/out.tif
    2020-02-10 11:04:04 (INFO) EdgeExtraction: Default RAM limit for OTB is 256 MB
    2020-02-10 11:04:04 (INFO) EdgeExtraction: GDAL maximum cache size is 794 MB
    2020-02-10 11:04:04 (INFO) EdgeExtraction: OTB will use at most 12 threads
    2020-02-10 11:04:04 (INFO): Estimated memory for full processing: 10.9486MB (avail.: 256 MB), optimal image partitioning: 1 blocks
    2020-02-10 11:04:04 (INFO): File /tmp/out.tif will be written in 1 blocks of 614x512 pixels
    Writing /tmp/out.tif...: 100% [**************************************************] (0s)

    this is not tested in otb (I think), but tests relying on network connections have a tendency to be random ... So maybe we can just merge this.

    Edited by Cédric Traizet
  • We could test it with a local HTTP server, but I don't think it's worth it. It's a GDAL feature, not an OTB one, and we just need to not do anything that breaks it.

  • mentioned in commit a9340fdf

Please register or sign in to reply
Loading