Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
otb
otb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 305
    • Issues 305
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 15
    • Merge Requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge Requests
  • !696

Merged
Created Feb 25, 2020 by Cédric Traizet@ctraizetDeveloper

Fix warnings

  • Overview 8
  • Commits 21
  • Pipelines 25
  • Changes 21

Summary

Closes #2015 (closed)

Current state of this MR: all warning should be cleaned on the fast build, I created the MR to trigger builds on all platforms and with the packaged remote modules.

Implementation Details

Fixed warning are :

  • comparison of two values with different enumeration types in switch statement in mvdImageViewWidget.cxx : QSurfaceFormat and QGLFormat are in practice the same enums, but the compiler can't know that !

  • !678 (merged) fixed a warning (returning temporary initializer_list does not extend the lifetime of the underlying array) but created another one (expression result unused, on Clang 6.0). The "unused result" is a dummy initalizer_list used for pack expansion. See for example this article for explanations on this trick.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Mar 27, 2020 by Cédric Traizet
Assignee
Assign to
Reviewer
Request review from
7.2.0
Milestone
7.2.0
Assign milestone
Time tracking
Source branch: fix_warnings