ENH: Use std::move instead of boost::move

Summary

Use the standard library move function.

Rationale

We're on C++14, so we can just the standard library move function.

Also, avoid calling move in cases where it's actually a pessimization, see e.g. https://reviews.llvm.org/D7633.

Additional notes

r? @lhermitte

Copyright

The copyright owner is Laurențiu Nicola / CS ROMANIA and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

Modules/Adapters/GdalAdapters/include/otbGeometriesToGeometriesFilter.hxx

@@ -46,7 +46,7 @@ inline
     /*virtual*/
     void
     otb::DefaultGeometriesToGeometriesFilter<TransformationFunctor, FieldTransformationPolicy>::DoProcessLayer(otb::ogr::Layer const& source,
-                                                                                                               otb::ogr::Layer& destination) const
+                                                                                                               otb::ogr::Layer&       destination) const
 {
   if (source != destination)
   {
@@ -83,15 +83,14 @@ inline void otb::TransformationFunctorDispatcher<TransformationFunctor, otb::ogr
 /*===========================================================================*/
 template <class TransformationFunctor, class FieldTransformationPolicy>
 inline void otb::TransformationFunctorDispatcher<TransformationFunctor, OGRGeometry, FieldTransformationPolicy>::operator()(otb::ogr::Layer const& in,
-                                                                                                                            otb::ogr::Layer& out) const
+                                                                                                                            otb::ogr::Layer&       out) const
 {
   OGRFeatureDefn& defn = out.GetLayerDefn();
   for (ogr::Layer::const_iterator b = in.begin(), e = in.end(); b != e; ++b)
   {
-    ogr::Feature const     feat = *b;
-    ogr::UniqueGeometryPtr g    = m_functor(feat.GetGeometry());
-    ogr::Feature           dest(defn);
-    dest.SetGeometryDirectly(otb::move(g));
+    ogr::Feature const feat = *b;
+    ogr::Feature       dest(defn);
+    dest.SetGeometryDirectly(m_functor(feat.GetGeometry()));
     this->fieldsTransform(feat, dest);
     out.CreateFeature(dest);
   }
@@ -108,8 +107,7 @@ inline void otb::TransformationFunctorDispatcher<TransformationFunctor, OGRGeome
   {
     ogr::Feature feat = *inout.start_at(i);
     this->fieldsTransform(feat);
-    ogr::UniqueGeometryPtr g = m_functor(feat.GetGeometry());
-    feat.SetGeometryDirectly(otb::move(g));
+    feat.SetGeometryDirectly(m_functor(feat.GetGeometry()));
     inout.SetFeature(feat);
   }
 }