Superbuild compilation with gcc-8

Summary

Fix the compilation of otb with GCC-8.

Patch by @gpasero

closes #1718 (closed)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

changed milestone to %7.4.0

changed title from Superbuild cmpilation with gcc-8 to Superbuild compilation with gcc-8

added 9 commits

• 72352e25...5c0b7ae9 - 8 commits from branch release-7.4
• 2dbfeb17 - BUG: add patch to fix compilation of ossim with gcc 8

Compare with previous version

mentioned in issue #2209 (closed)

mentioned in commit 4248972c

merged