Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • otb otb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 189
    • Issues 189
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main Repositories
  • otbotb
  • Merge requests
  • !839

Rename the noise parameter in SARCalibration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cédric Traizet requested to merge sarcalibration_remove_noise_parameter into release-7.4 Aug 02, 2021
  • Overview 1
  • Commits 2
  • Pipelines 4
  • Changes 3

Summary

There is a noise bool parameter SARcalibration. setting this parameter to true disable the noise removal step of the calibration. This is not clear, for example the command line

otbcli_SARCalibration -in input.tif -out output.tif -noise true

could be understood wrongly as the calibration of input.tif with noise removal.

This Merge Request introduces a removenoise parameter to clear this ambiguity, when removenoise is set to true, the noise is removed if the input sensor supports it. The documentation has also been updated to state which sensor support noise removal (Sentinel 1 and TerraSAR-X).

For now, noise is deprecated, as removing it directly would break the API. The parameter will be definitely removed in OTB 8.0.

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 👍 votes from core developers, no 👎 vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited Aug 02, 2021 by Cédric Traizet
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: sarcalibration_remove_noise_parameter