Release 7.4 (integration into develop)

Summary

Merge the release-7.4 branch into develop, fix conflicts and backport breaking changes (WIP).

This is part of the release process. See #2209 (closed)

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.

---

Check before merging:

• All discussions are resolved
• At least 2 votes from core developers, no vote.
• The feature branch is (reasonably) up-to-date with the base branch
• Dashboard is green
• Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
• Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit

changed milestone to %7.4.0

assigned to @ctraizet

added 8 commits

• f1df5bc6 - REFAC: use ImageMetadata instead of keywordlists in S1ThermalNoiseLutTest
• 72589227 - REFAC: move Sentinel1ThermalNoiseLookupData from OTBSarCalibration to...
• e06d5cdd - REFAC: use ImageMetadata instead of keywordlists in Sentinel 1 thermal denoising
• 0916717d - REFAC: update baseline for apTvRaSARCalibration_SENTINEL1_recent_noise...
• c919a439 - REFAC: remove deprecated code
• 82b1bfb4 - WRG: fix initialization order warnings
• 90a9ac81 - WRG: warning fixes
• f7b253fd - REFAC: remove deprecated parameter noise in SARCalibration

Compare with previous version

changed the description

added refactoring label

added 3 commits

• 0ef13638 - REFAC: remove unused metadata SarParam.SARNoise
• d4f74271 - BUG: fetch the correct sensorID for Sentinel 1 (Sentinel-1A or Sentinel-1B)...
• a38e970b - REFAC: adapt the SarCalibrationLookupDataTest to use ImageMetadata instead of keywordlist

Compare with previous version

added 2 commits

• d349f3f5 - BUG: correct SensorID for Radarsat 2
• 04d25402 - TEST: bring back otb 7.4 baselines for Sentinel 1 and Radarsat 2 Calibration lut tests

Compare with previous version

added 1 commit

• e662269b - BUG: fix time parsing in TerraSarXSarSensorModel when using Boost time

Compare with previous version

added 2 commits

• fc5e7f27 - TEST: update baseline for raTvSarBrightnessToImageWithComplexPixelFilter (see...
• 2d8fc584 - BUG: fix inverted line/row in GetRadiometricCalibrationNoise and convert ato...

Compare with previous version

I found a bug in !828 (merged). double TerraSarXSarImageMetadataInterface::ConvertStringTimeUTCToJulianDay(const std::string& value) converts a date in string format to Julian Day. The date components are first extracted from the input string, and then the conversion formula is applied (according according to http://en.wikipedia.org/wiki/Julian_day). However, apart from the second component, the TerraSarXSarImageMetadataInterface date getters (GetYear, GetMonth etc) were used instead of the input string. These getters return the date corresponding to the first line, which is not the necessary the same thing as the input date string. I corrected the bug in the release-7.4 branch and updated the baseline of the affected tests.

added 27 commits

• 2d8fc584...5c096f44 - 24 commits from branch develop
• 20b8e6d8 - STY: fix identation in InternalWriteImageInformation (Allman style)
• 33a58018 - Merge remote-tracking branch 'origin/develop' into integration_release-7.4
• 570bfd36 - REFAC: update release notes for OTB 7.4.0-rc2

Compare with previous version

added 1 commit

• de6d1745 - REFAC: update release notes for OTB 7.4.0

Compare with previous version

merged

mentioned in commit 9c7336db