Skip to content
Snippets Groups Projects

Correctly take into account the extended filename writerpctag

Merged Julien Osman requested to merge 2295-fix-extended-filename-writerpctags into develop

Summary

The extended filename writerpctag was not taken into account. With this MR, the output image will contain the RPC model if writerpctag=true even if the proejction is present.

Rationale

Fix #2295 (closed)

Implementation Details

Classes and files
  • Modules/IO/IOGDAL/include/otbGDALImageIO.h: New class function GDALMetadataWriteRPC
  • Modules/IO/IOGDAL/src/otbGDALImageIO.cxx: Call GDALMetadataWriteRPC when writerpctag=true

Copyright

The copyright owner is CNES and has signed the ORFEO ToolBox Contributor License Agreement.


Check before merging:

  • All discussions are resolved
  • At least 2 :thumbsup: votes from core developers, no :thumbsdown: vote.
  • The feature branch is (reasonably) up-to-date with the base branch
  • Dashboard is green
  • Copyright owner has signed the ORFEO ToolBox Contributor License Agreement
  • Optionally, run git diff develop... -U0 --no-color | clang-format-diff.py -p1 -i on latest changes and commit
Edited by Julien Osman

Merge request reports

Merge request pipeline #11230 passed

Merge request pipeline passed for 3b561845

Merged by Julien OsmanJulien Osman 2 years ago (Aug 10, 2022 12:24pm UTC)

Loading

Pipeline #11250 passed

Pipeline passed for 47c7fd7e on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luc Hermitte
  • Luc Hermitte
  • mentioned in issue #2295 (closed)

  • Julien Osman resolved all threads

    resolved all threads

  • Julien Osman added 2 commits

    added 2 commits

    • bd61db03 - ENH: Avoid importing otbGDALDriverManagerWrapper in the header file
    • 48af0ff2 - ENH: Add compilation-time check on memcpy

    Compare with previous version

  • Julien Osman marked this merge request as ready

    marked this merge request as ready

  • Julien Osman added 1 commit

    added 1 commit

    • 5f2a1b3b - BUG: Correctly assert array's size

    Compare with previous version

  • Julien Osman added 1 commit

    added 1 commit

    • 8bfd5c83 - BUG: Read the size of array with iterators

    Compare with previous version

  • Julien Osman added 1 commit

    added 1 commit

    • 294c9385 - BUG: Read the size of array with iterators

    Compare with previous version

  • Julien Osman added 1 commit

    added 1 commit

    • c4547440 - BUG: Define getsize_tab to assert the size of arrays

    Compare with previous version

  • Julien Osman added 1 commit

    added 1 commit

    • 3b561845 - BUG: Define getsize_tabs to assert the size of arrays

    Compare with previous version

  • Julien Osman approved this merge request

    approved this merge request

  • Julien Osman unapproved this merge request

    unapproved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading